Skip to content

Clean up some leaked variables in completion functions. #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Clean up some leaked variables in completion functions. #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16a053c
Stop leaking `branch_names` variable in git completion.
kevincox Oct 7, 2025
a8cacaf
Don't leak `lstate` variable in ssh completion.
kevincox Oct 7, 2025
1b77d79
Don't leak `khosts` variable in hosts completion.
kevincox Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Completion/Unix/Command/_git
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7099,7 +7099,7 @@ __git_remote_branch_names () {
__git_remote_branch_names_noprefix () {
declare -a heads

branch_names=(${${${${(f)"$(_call_program remote-branch-refs-noprefix git for-each-ref --format='"%(refname)"' refs/remotes 2>/dev/null)"}#refs/remotes/}#*/}:#HEAD})
local branch_names=(${${${${(f)"$(_call_program remote-branch-refs-noprefix git for-each-ref --format='"%(refname)"' refs/remotes 2>/dev/null)"}#refs/remotes/}#*/}:#HEAD})
__git_command_successful $pipestatus || return 1

__git_describe_commit branch_names remote-branch-names-noprefix 'remote branch name' "$@"
Expand Down
2 changes: 1 addition & 1 deletion Completion/Unix/Command/_ssh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# TODO: sshd, ssh-keysign

_ssh () {
local curcontext="$curcontext" state line expl suf arg ret=1
local curcontext="$curcontext" state line lstate expl suf arg ret=1
local args sigargs common common_transfer options algopt tmp p1 file cmn cmds sdesc tdesc
typeset -A opt_args tsizes

Expand Down
2 changes: 1 addition & 1 deletion Completion/Unix/Type/_hosts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ if ! zstyle -a ":completion:${curcontext}:hosts" hosts _hosts; then

for khostfile in $khostfiles; do
if [[ -r $khostfile ]]; then
khosts=(${(s/,/j/,/u)${(f)"$(<$khostfile)"}%%[ |#]*})
local khosts=(${(s/,/j/,/u)${(f)"$(<$khostfile)"}%%[ |#]*})

# known_hosts syntax supports the host being in the form [hostname]:port
# The filter below extracts the hostname from lines using this format.
Expand Down