Skip to content

refactor(tensor): rename TensorDataIndexView and TensorDataIndexMutView to TensorDataView and TensorDataViewMut, add TensorDataViewExt with expect_view and try_view methods, and update all references accordingly - #155

Merged
crutcher merged 3 commits into
mainfrom
crutcher/data_view
Aug 6, 2026

Conversation

@crutcher

@crutcher crutcher commented Aug 5, 2026

Copy link
Copy Markdown
Member

No description provided.

…tView` to `TensorDataView` and `TensorDataViewMut`, add `TensorDataViewExt` with `expect_view` and `try_view` methods, and update all references accordingly
@crutcher

crutcher commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@laggui: a few questions about the TensorData extension names?

  • data.{try,expect}_view() vs data.{try,expect}_index_view()
  • Same, but index_mut_view?

Also, notice that I'm re-impl the TensorData::matches_target_dtype method, which is currently private (that needs to change).

…x_view` and `try_index_view`, update all references accordingly
@crutcher

crutcher commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

I switched to {try,expect}_index{,_mut}_view()

@crutcher
crutcher merged commit 9e6d765 into main Aug 6, 2026
3 checks passed
@crutcher
crutcher deleted the crutcher/data_view branch August 6, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant