Refactor Electron setup and improve MCP server management #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced Electron's window creation process with additional configurations, including handling macOS-specific requirements and custom protocols. Added states and validation for custom MCP server configurations, improving usability and error handling in the MCP server management component.
Enabled fullscreen mode for the application window and refined macOS behavior by removing unnecessary settings, file checks, and event handlers. Simplified window lifecycle management to enhance maintainability.
This commit deletes `main.js` and `preload.js` from the `dist-electron` directory. These files appear to no longer be required, possibly due to a shift in the build process or architecture. The removal helps streamline the distribution package by excluding unnecessary artifacts.
Added a command to remove existing build directories (`dist` and `dist-electron`) to ensure a clean rebuild process during MacOS application packaging. This prevents potential issues caused by leftover files from previous builds.
Renamed "Known Issues" to "Work to be done" and clarified ongoing tasks with a more optimistic tone. Encouraged contributions to address these pending items.
|
hey @silviusimeria thank you so much for making MCP manager even better! i'd like to add an automated build pipeline to push new releases, but I'm not super familiar with electron do you have any github actions you could share? |
|
hey, i managed to get a github action working to build a dmg, but it doesnt seem to be showing up in releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.