Fix dark mode bgMessageRegular color to match Figma design

[loveucifer]

This change addresses issue #1685: DesignVariables.bgMessageRegular was slightly wrong in dark mode.

Changed the dark mode bgMessageRegular value from HSLColor.fromAHSL(1, 0, 0, 0.11).toColor() to const Color(0xff1d1d1d) to match the Figma design where bg-message-regular variable in dark mode is #1D1D1D.

Before	After

[chrisbobbe]

#1715 (comment)

Thanks. Can you post a pair of screenshots that are as similar as possible except for your change? With the current screenshots it's difficult to tell what's caused by your change, because all the content in the screenshots is different.

Using Flutter's hot reload: https://docs.flutter.dev/tools/hot-reload it should be possible to switch quickly back and forth between the "before" and "after" versions of the code, without leaving your place in the running app. That should make it possible to get pretty much the exact same shot in both "before" and "after".

[chrisbobbe]

Also please format your commit message according to the project style: https://github.com/zulip/zulip-mobile/blob/main/docs/style.md#git-commits-commit-messages

[loveucifer]

#1715 (comment)

Thanks. Can you post a pair of screenshots that are as similar as possible except for your change? With the current screenshots it's difficult to tell what's caused by your change, because all the content in the screenshots is different.
Using Flutter's hot reload: https://docs.flutter.dev/tools/hot-reload it should be possible to switch quickly back and forth between the "before" and "after" versions of the code, without leaving your place in the running app. That should make it possible to get pretty much the exact same shot in both "before" and "after".

also a review on this please i think i recently solved some conflicts as well which occurred #1759. thanks

[chrisbobbe]

also dont know why this was marked as spam :/

It takes up a lot of vertical space, so it's annoying to scroll past. Instead of posting new messages, please update the pair of screenshots in the issue description, making them identical except for the change you're asking us to review. We've asked you multiple times already and suggested an easy way to do this, with Flutter's "hot reload" feature. It's important in this case where the change is so subtle and easy to miss in the noise.

Currently there are irrelevant differences:

• Topic narrow vs. channel narrow
• Unread marker present vs. absent on a message