Skip to content

Conversation

chrisbobbe
Copy link
Collaborator

The toggle design seems to have changed slightly since we implemented it:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=6070-60763&m=dev

Looks like it was just this one detail.

@chrisbobbe chrisbobbe added the maintainer review PR ready for review by Zulip maintainers label Oct 1, 2025
@chrisbobbe
Copy link
Collaborator Author

chrisbobbe commented Oct 1, 2025

cc @alya

The only change is in the "off" position, but oops I've already taken screenshots of the "on" position. :)

  • In dark mode, the "thumb" is now dark in the "off" position.
  • In light mode, the "thumb" is now very slightly grayish in the "off" position, instead of pure white.
Before After
image image
image image
image image
image image

Copy link
Member

@rajveermalviya rajveermalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrisbobbe! LGTM, moving over to Greg's review.

@rajveermalviya rajveermalviya added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Oct 3, 2025
@rajveermalviya rajveermalviya requested a review from gnprice October 3, 2025 17:00
@gnprice
Copy link
Member

gnprice commented Oct 3, 2025

Thanks! Looks good; merging.

(I see Alya has given a 👍 to the comment with screenshots.)

The toggle design seems to have changed slightly since we
implemented it:
  https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=6070-60763&m=dev

Looks like it was just this one detail.
@gnprice gnprice force-pushed the pr-update-toggle-thumb-color branch from 371aadb to aaff63f Compare October 3, 2025 22:31
@gnprice gnprice merged commit aaff63f into zulip:main Oct 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants