Skip to content

compose_box: Add start video call button in compose #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

compose_box: Add start video call button in compose #1916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d90df43
icons: Add 'video', from the Figma
MritunjayTiwari14 Oct 17, 2025
5898952
api: Add realmVideoChatProvider and jitsiServerUrl to InitialSnapshot
MritunjayTiwari14 Oct 17, 2025
d5bbd96
realm: Add getters for jitsiServerUrl and realmVideoChatProvider
MritunjayTiwari14 Oct 17, 2025
2ea8602
compose: Add video chat button to compose box
MritunjayTiwari14 Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/icons/ZulipIcons.ttf
View file
Open in desktop
Binary file not shown.
8 changes: 8 additions & 0 deletions assets/icons/video.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions assets/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,10 @@
"@composeBoxAttachFromCameraTooltip": {
"description": "Tooltip for compose box icon to attach an image from the camera to the message."
},
"composeBoxAttachFromVideoCallTooltip": "Attach a video call",
"@composeBoxAttachFromVideoCallTooltip": {
"description": "Tooltip for compose box icon to attach a video call url to the message."
},
Comment on lines +577 to +580
Copy link
Collaborator

@chrisbobbe chrisbobbe Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like web says "Add video call". Let's follow that, for consistency.

Also this is misnamed; we're not "attaching from a video call". Let's call it composeBoxAddVideoCallTooltip.

Copy link
Collaborator

@chrisbobbe chrisbobbe Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please fix the indentation so it's consistent with other entries here.

"composeBoxGenericContentHint": "Type a message",
"@composeBoxGenericContentHint": {
"description": "Hint text for content input when sending a message."
Expand Down Expand Up @@ -654,6 +658,10 @@
"filename": {"type": "String", "example": "file.txt"}
}
},
"composeBoxUploadedVideoCallUrl": "Join video call.",
"@composeBoxUploadedVideoCallUrl": {
"description": "Placeholder in compose box showing the video call url is generated."
},
Comment on lines +661 to +664
Copy link
Collaborator

@chrisbobbe chrisbobbe Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about composeBoxVideoCallLinkText for the name, and for the description, "Text for a Markdown link to a video-call URL."

Also please fix the indentation.

"composeBoxLoadingMessage": "(loading message {messageId})",
"@composeBoxLoadingMessage": {
"description": "Placeholder in compose box showing the quoted message is currently loading.",
Expand Down
6 changes: 6 additions & 0 deletions lib/api/model/initial_snapshot.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ class InitialSnapshot {
/// Search for "realm_wildcard_mention_policy" in https://zulip.com/api/register-queue.
final RealmWildcardMentionPolicy realmWildcardMentionPolicy;

final int realmVideoChatProvider;
Copy link
Collaborator

@chrisbobbe chrisbobbe Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make an enum for this; see maybe CustomProfileFieldType for an example to follow.

Also please follow the comment at the top of InitialSnapshot:

  // Keep these fields in the order they appear in the API docs.
  // (For many API types we choose a more logical order than the docs.
  // But this one is so long that that'd make it become impossible to
  // compare the lists by hand.)


final bool realmMandatoryTopics;

final String realmName;
Expand All @@ -115,6 +117,8 @@ class InitialSnapshot {

final Map<String, RealmDefaultExternalAccount> realmDefaultExternalAccounts;

final String? jitsiServerUrl;
Copy link
Collaborator

@chrisbobbe chrisbobbe Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading the doc, there are actually three related fields to handle:

  • jitsi_server_url
  • realm_jitsi_server_url
  • server_jitsi_server_url

Let's add realmVideoChatProvider in its own separate commit, but we can add these three related fields together.


final int maxFileUploadSizeMib;

final Uri serverEmojiDataUrl;
Expand Down Expand Up @@ -184,6 +188,7 @@ class InitialSnapshot {
required this.realmDeleteOwnMessagePolicy,
required this.realmWildcardMentionPolicy,
required this.realmMandatoryTopics,
required this.realmVideoChatProvider,
required this.realmName,
required this.realmWaitingPeriodThreshold,
required this.realmMessageContentDeleteLimitSeconds,
Expand All @@ -193,6 +198,7 @@ class InitialSnapshot {
required this.realmIconUrl,
required this.realmPresenceDisabled,
required this.realmDefaultExternalAccounts,
required this.jitsiServerUrl,
required this.maxFileUploadSizeMib,
required this.serverEmojiDataUrl,
required this.realmEmptyTopicDisplayName,
Expand Down
4 changes: 4 additions & 0 deletions lib/api/model/initial_snapshot.g.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions lib/generated/l10n/zulip_localizations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,12 @@ abstract class ZulipLocalizations {
/// **'Take a photo'**
String get composeBoxAttachFromCameraTooltip;

/// Tooltip for compose box icon to attach a video call url to the message.
///
/// In en, this message translates to:
/// **'Attach a video call'**
String get composeBoxAttachFromVideoCallTooltip;

/// Hint text for content input when sending a message.
///
/// In en, this message translates to:
Expand Down Expand Up @@ -1029,6 +1035,12 @@ abstract class ZulipLocalizations {
/// **'Uploading {filename}…'**
String composeBoxUploadingFilename(String filename);

/// Placeholder in compose box showing the video call url is generated.
///
/// In en, this message translates to:
/// **'Join video call.'**
String get composeBoxUploadedVideoCallUrl;

/// Placeholder in compose box showing the quoted message is currently loading.
///
/// In en, this message translates to:
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_ar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,9 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Take a photo';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Type a message';

Expand Down Expand Up @@ -544,6 +547,9 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
return 'Uploading $filename…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(loading message $messageId)';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_de.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,9 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Ein Foto aufnehmen';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Eine Nachricht eingeben';

Expand Down Expand Up @@ -563,6 +566,9 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
return 'Lade $filename hoch…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(lade Nachricht $messageId)';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_el.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,9 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Take a photo';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Type a message';

Expand Down Expand Up @@ -544,6 +547,9 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
return 'Uploading $filename…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(loading message $messageId)';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_en.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,9 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Take a photo';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Type a message';

Expand Down Expand Up @@ -544,6 +547,9 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
return 'Uploading $filename…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(loading message $messageId)';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_es.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,9 @@ class ZulipLocalizationsEs extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Take a photo';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Type a message';

Expand Down Expand Up @@ -544,6 +547,9 @@ class ZulipLocalizationsEs extends ZulipLocalizations {
return 'Uploading $filename…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(loading message $messageId)';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_fr.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,9 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Take a photo';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Type a message';

Expand Down Expand Up @@ -560,6 +563,9 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
return 'Uploading $filename…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(loading message $messageId)';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_he.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,9 @@ class ZulipLocalizationsHe extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Take a photo';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Type a message';

Expand Down Expand Up @@ -544,6 +547,9 @@ class ZulipLocalizationsHe extends ZulipLocalizations {
return 'Uploading $filename…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(loading message $messageId)';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_hu.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,9 @@ class ZulipLocalizationsHu extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Take a photo';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Type a message';

Expand Down Expand Up @@ -544,6 +547,9 @@ class ZulipLocalizationsHu extends ZulipLocalizations {
return 'Uploading $filename…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(loading message $messageId)';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_it.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,9 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Fai una foto';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Batti un messaggio';

Expand Down Expand Up @@ -557,6 +560,9 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
return 'Caricamento $filename…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(caricamento messaggio $messageId)';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_ja.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,9 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => '写真を撮る';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'メッセージを入力';

Expand Down Expand Up @@ -532,6 +535,9 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
return '$filename をアップロード中…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '（メッセージ $messageId を読み込み中）';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_nb.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,9 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Take a photo';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Type a message';

Expand Down Expand Up @@ -544,6 +547,9 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
return 'Uploading $filename…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(loading message $messageId)';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_pl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,9 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Zrób zdjęcie';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Wpisz wiadomość';

Expand Down Expand Up @@ -557,6 +560,9 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
return 'Przekazywanie $filename…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(ładowanie wiadomości $messageId)';
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations_ru.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,9 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
@override
String get composeBoxAttachFromCameraTooltip => 'Сделать снимок';

@override
String get composeBoxAttachFromVideoCallTooltip => 'Attach a video call';

@override
String get composeBoxGenericContentHint => 'Ввести сообщение';

Expand Down Expand Up @@ -558,6 +561,9 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
return 'Загрузка $filename…';
}

@override
String get composeBoxUploadedVideoCallUrl => 'Join video call.';

@override
String composeBoxLoadingMessage(int messageId) {
return '(загрузка сообщения $messageId)';
Expand Down
Loading