Skip to content

Fix phpcs error after cakephp-codesniffer 5.3.0 release#14

Merged
zunnu merged 1 commit intozunnu:mainfrom
josbeir:main
Sep 22, 2025
Merged

Fix phpcs error after cakephp-codesniffer 5.3.0 release#14
zunnu merged 1 commit intozunnu:mainfrom
josbeir:main

Conversation

@josbeir
Copy link
Copy Markdown
Contributor

@josbeir josbeir commented Sep 22, 2025

Fixes phpcs fails
Adds local license file

Copilot AI review requested due to automatic review settings September 22, 2025 11:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes phpcs configuration issues after cakephp-codesniffer 5.3.0 release and adds a local MIT license file.

  • Removed deprecated installed_paths configuration from phpcs.xml
  • Updated README.md to reference local license file instead of external URL
  • Added complete MIT license text in LICENSE.md

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
phpcs.xml Removed deprecated installed_paths config that was causing phpcs errors
README.md Updated MIT license reference to point to local LICENSE.md file
LICENSE.md Added complete MIT license text with 2025 copyright

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread LICENSE.md
@zunnu
Copy link
Copy Markdown
Owner

zunnu commented Sep 22, 2025

Thanks for fixing the actions errors too. It was driving me up the wall

@zunnu zunnu merged commit 428cd2d into zunnu:main Sep 22, 2025
4 checks passed
@dereuromark
Copy link
Copy Markdown

License is not valid as is!

@zunnu
Copy link
Copy Markdown
Owner

zunnu commented Sep 22, 2025

License is not valid as is!

@dereuromark
Im not familiar with licensing so can you give bit more context?
Github says this repo is under MIT license and that's the license I want for it. I can add Copyright (c) 2025 Zunnu or Copyright (c) 2025 Cake-htmx contributors if that makes it more valid?
image

@dereuromark
Copy link
Copy Markdown

See code review
I would think it knows how to read valid license head

@zunnu
Copy link
Copy Markdown
Owner

zunnu commented Sep 22, 2025

See code review I would think it knows how to read valid license head

@dereuromark Added the author's name and the original release year in #15
As that's when the original license was informed in the readme as intent to release the code under MIT.
I don't think the missing name does negate the license and under the Berne Convention, creations are automatically copyrighted whether or not the notice exist but Im not a lawyer so can't say for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants