Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow page to take full width for pages without TOC #701

Closed
wants to merge 3 commits into from

Conversation

mosch
Copy link
Contributor

@mosch mosch commented Feb 18, 2025

No description provided.

@mosch mosch added the bug Something isn't working label Feb 18, 2025
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zudoku-cosmo-cargo ✅ Ready (Inspect) Visit Preview Feb 18, 2025 11:54am
zudoku-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 11:54am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
zudoku-www ⬜️ Skipped (Inspect) Feb 18, 2025 11:54am

Copy link

nx-cloud bot commented Feb 18, 2025

View your CI Pipeline Execution ↗ for commit 18785fc.

Command Status Duration Result
nx run-many -t build --projects=tag:example ✅ Succeeded 1m 15s View ↗
nx run-many -t lint:ci format:ci build:ci test ✅ Succeeded 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-18 11:55:06 UTC

@dan-lee
Copy link
Contributor

dan-lee commented Feb 18, 2025

I don't think we can just remove the max-width, e.g. Configuration is now slightly broken (maybr other pages too)

Can't we just increase the prose max-width? The default is 65ch which might be too narrow, but we could up it to 80ch or 100ch.

CleanShot 2025-02-18 at 11 39 25

@mosch
Copy link
Contributor Author

mosch commented Feb 18, 2025

@dan-lee yeah, mb. The idea was to give the content the room it has if there is no TOC. I fixed that so we can use the full space without TOC.

@mosch
Copy link
Contributor Author

mosch commented Feb 19, 2025

closed in fav of #707

@mosch mosch closed this Feb 19, 2025
@mosch mosch deleted the toc-page-width branch February 19, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants