URL encode request URIs by default #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are any non-ASCII characters in the request URI, curl will send those through in raw UTF-8 form by default. That is almost never what you'd want, since all server frameworks will expect non-ASCII characters to be percent-encoded. The built-in url-encode-url function does exactly that, so we pass our request URI through it.
|
Dear, Is there any chance this PR been merged ? I think that's really very reasonable to send encode URL. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are any non-ASCII characters in the request URI,
curlwill sendthose through in raw UTF-8 form by default. That is almost never what
you'd want, since all server frameworks will expect non-ASCII characters
to be percent-encoded.
The built-in
url-encode-urlfunction does exactly that, so we pass ourrequest URI through it.
Please let me know if this should be a switch instead; I couldn't think of a case where you wouldn't want this.