Skip to content

Require explicit opt-in for embedded MCP fallback - #552

Merged
zzet merged 4 commits into
mainfrom
fix/mcp-embedded-fallback-opt-in
Aug 12, 2026
Merged

Require explicit opt-in for embedded MCP fallback#552
zzet merged 4 commits into
mainfrom
fix/mcp-embedded-fallback-opt-in

Conversation

@zzet

@zzet zzet commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • require explicit machine-global mcp.allow_embedded: true before gortex mcp may start the legacy one-shot embedded server
  • default to a clear error when no compatible daemon is available, preventing multiple MCP clients from silently creating duplicate indexers
  • fail closed on malformed global config and prevent repository-local .gortex.yaml from granting this machine-level permission
  • preserve --proxy as daemon-only, surface permission/broken-socket failures, and prevent cancellation from falling through to embedded startup
  • document the new default and expose it in the generated global config template

Opt in to legacy behavior

# ~/.gortex/config.yaml
mcp:
  allow_embedded: true

Without this setting, users should start the shared daemon with gortex daemon start.

Testing

  • go test -race -timeout=20m ./... (clean normal clone with isolated user/daemon state)
  • go build ./cmd/gortex/... ./internal/daemon/...
  • go test -race ./cmd/gortex/... ./internal/daemon/...
  • make lint
  • git diff --check origin/main...HEAD

Follow-up to #418.

@zzet
zzet merged commit de6ffb0 into main Aug 12, 2026
12 checks passed
@zzet
zzet deleted the fix/mcp-embedded-fallback-opt-in branch August 15, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant