Skip to content

Conversation

LukeChannings
Copy link

The _1password package was renamed to _1password-cli in nixpkgs.

Using the _1password package prints the following:

evaluation warning: _1password has been renamed to _1password-cli to better follow upstream name usage

This PR is similar to #498, but they missed the invocation on line 11 so it still prints the warning.

Changes

  • Add a cliPackage option, which defaults to _1password-cli. Users may want to use a custom version of the 1Password CLI without using an overlay - this provides that option.
  • The evaluation message is no longer printed

Copy link
Contributor

github-actions bot commented Jan 6, 2025

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@bjeanes
Copy link

bjeanes commented Jan 26, 2025

Closes #496 #498

@SimonBarendse SimonBarendse mentioned this pull request Apr 24, 2025
@anaclumos
Copy link

Would love to hear if there are any updates on this!

@RyanPrussin
Copy link
Contributor

I just made #528, but realized after the fact that this exists and is probably a better and more flexible implementation.

This update has even been approved by multiple reviewers -- what is holding it back?

@mrjones2014
Copy link
Member

This is solved in a slightly more conventional way by #471, closing in favor of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants