Skip to content

Make 1Password CLI package configurable and fix pkgs._1password warning #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make 1Password CLI package configurable and fix pkgs._1password warning #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions nix/shell-plugins.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ let
pkgs.runCommand "op-plugin-list" { }
# 1Password CLI tries to create the config directory automatically, so set a temp XDG_CONFIG_HOME
# since we don't actually need it for this
"mkdir $out && XDG_CONFIG_HOME=$out ${pkgs._1password}/bin/op plugin list | cut -d ' ' -f1 | tail -n +2 > $out/plugins.txt"
"mkdir $out && XDG_CONFIG_HOME=$out ${getExe cfg.cliPackage} plugin list | cut -d ' ' -f1 | tail -n +2 > $out/plugins.txt"
}/plugins.txt");
getExeName = package:
# NOTE: SAFETY: This is okay because the `packages` list is also referred
Expand All @@ -21,6 +21,13 @@ in {
options = {
programs._1password-shell-plugins = {
enable = mkEnableOption "1Password Shell Plugins";
cliPackage = mkOption {
type = types.package;
default = pkgs._1password-cli;
description = ''
The 1Password CLI package
'';
};
plugins = mkOption {
type = types.listOf types.package;
default = [ ];
Expand Down Expand Up @@ -62,7 +69,7 @@ in {
name = package;
value = "op plugin run -- ${package}";
}) pkg-exe-names);
packages = [ pkgs._1password ] ++ cfg.plugins;
packages = [ cfg.cliPackage ] ++ cfg.plugins;
in mkIf cfg.enable (mkMerge [
({
programs = {
Expand Down
Loading