Issue #5359 - Extend utility scripts to find out quota and its usage #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses to a given teamspace
…es, fixed bug where active licenses are displayed if a single license is expired, ensure calculated quota only includes licenses of a valid type
…compare expected expired licenses against the actual ones
…ExpiredLicenses, added some common abstractions between them
…ave a valid format by including subscriptions type
jacobcons
changed the title
|
@carmenfan Just tagging you here because I can't request a review without write access to the repo 😄 |
|
@jacobcons all good, I saw it. Just a bit preoccupied to have a look! Thank you for contributing 😄 |
|
@carmenfan No worries at all! 😄 |
carmenfan
requested changes
Feb 12, 2025
…scriptions and defaults, add tests for full coverage, refactoring of teamspacesetting license functions to be a bit more efficient
|
@carmenfan Should all be good now 😄 |
|
Hey @carmenfan, just following up on this PR. Would love to get your thoughts when you have a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5359
Description
allExpiredLicensesandallActiveLicensesscripts, include data quota usage, and license count data for the teamspace the license belongs toallExpiredLicenseswould include active licenses as long as it belongs to a teamspace with at least one expired license (and made a similar fix forallActiveLicenses)quotaInfoincludes licenses of an invalid typeTest cases
allExpiredLicensesandallActiveLicensesscripts, ensuring it's seeded with teamspaces that contain multiple licensesgetTeamspaceValidLicenses,extractTeamspaceActiveLicensesandextractTeamspaceExpiredLicensestestSufficientQuotatest to mock a db result of the correct format