-
Notifications
You must be signed in to change notification settings - Fork 14
0.2.0 #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bundle Size ChangesHello! 👋 This comment was generated by a Github Action to help you and reviewers understand the impact of your PR on frontend bundle sizes. Whenever this PR is updated, this comment will update to reflect the latest changes.
View detailed bundle informationAdded No assets were added Removed No assets were removed Bigger
Smaller
View module informationAdded
Removed
Bigger
Smaller No modules were smaller |
|
ace-svg-react/src/ACESVGjsPanel.tsx Lines 159 to 166 in 729c718
I don't think this is necessary. Basically will skip the proceeding logic of checking parent ID's if the clicked element does not have an ID. |
|
Apparently, hooks are not allowed in class components, so I had to use something like a higher order component to achieve the use of |
| private renderSVG(element: SVGSVGElement | SVGDom | null): string | null { | ||
| if (element) { | ||
| if ( | ||
| this.props.options.initSource !== this.state.initFunctionSource || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why there were so many state variables...you need them to determine if the panel needs to be reinitialized.
Playwright test results
|
In progress