ci(gfx11): install Node.js so llama-ui builds from source - #47
Merged
Conversation
roberteg16
approved these changes
Jul 13, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gfx11 ROCm build started failing at the
Provisioning UI assetsstep(
llama-ui-embed failed (1)->ninja: build stopped) after the recentupstream sync (PR #43) pulled in the new SvelteKit web UI and its
scripts/ui-assets.cmakeprovisioning (upstream ggml-org#22937 moved the prebuilt UIout of the repo and onto a HuggingFace bucket; ggml-org#23352 refactored the cmake
build).
ui-assets.cmakeprovisions the embedded web UI in three tiers:tools/ui/dist/(not present),The gfx11 runner has no
npm(UI: npm not found, skipping npm build), so itfell through to tier 3. There it 404'd on the pinned
b1bucket (the fork hasno real build number), fell back to the
latestbucket, and that archive isout of sync with the checked-out source: it extracted fine (cmake only checks
index.html) butllama-ui-embedrejected it for a missing required asset(
loading.html), which is fatal.Fix
Add an
actions/setup-node@v6step (node 24) before the build, matching whatupstream's own workflows (
release.yml,ui-build.yml) already use. With npmon PATH the build takes tier 2 and compiles the UI from the checked-out source,
so the assets always match
llama-ui-embedand there is no dependency on theHF bucket being in sync. This mirrors upstream behavior and self-heals across
future syncs.
Test plan
build-ubuntujob reaches and passes theProvisioning UI assetsstep