Skip to content

Handling of new crypto-rates.json#154

Merged
mdrlzy merged 10 commits into
mainfrom
feature/handling-new-crypto-rates
Jul 13, 2025
Merged

Handling of new crypto-rates.json#154
mdrlzy merged 10 commits into
mainfrom
feature/handling-new-crypto-rates

Conversation

@mdrlzy

@mdrlzy mdrlzy commented Jun 7, 2025

Copy link
Copy Markdown
Collaborator

✅ Changes

  • Compute fallback rates timestamp during build
  • During launch, set timestamp to minimum of the two
  • Extract SearchUseCase
  • If search term matches the code, ensure that the match is full prefix
  • In search screen display tokens without icons in the end

🔗 Related Tickets / Issues

@shubertm shubertm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offline rates are not updating correctly

@kirillt kirillt force-pushed the feature/handling-new-crypto-rates branch from 76262f1 to f13e447 Compare July 11, 2025 12:35

@shubertm shubertm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In SearchScreen, am still getting currencies without icons on top

Comment on lines +49 to +54
val currencies =
searchUseCase(
state.currencies,
state.currencies.map { it.code },
"",
)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currencies is now always empty
SearchUseCase is not needed here

@mdrlzy

mdrlzy commented Jul 12, 2025

Copy link
Copy Markdown
Collaborator Author

Remove GetTopResultUseCase.kt 👍
It can simply be replaced with CalcFrequentCurrUseCase

In SearchScreen, am still getting currencies without icons on top

If the query is empty, then currencies without icons are ok. If I understood correctly what you mean

@shubertm

Copy link
Copy Markdown
Contributor

Remove GetTopResultUseCase.kt 👍 It can simply be replaced with CalcFrequentCurrUseCase

In SearchScreen, am still getting currencies without icons on top

If the query is empty, then currencies without icons are ok. If I understood correctly what you mean

Yes, they come on top but in alphabetical order. When it is not empty the they come below those with icons in the same alphabetical order.
I get it now, my earlier thought was all without icons below, all with icons above, alphabetical sorting comes after that.

@shubertm shubertm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good :+!:

@mdrlzy mdrlzy merged commit db748b1 into main Jul 13, 2025
4 checks passed
@mdrlzy mdrlzy deleted the feature/handling-new-crypto-rates branch July 13, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants