Skip to content

Feature/285 example script on how to simulate faults#286

Merged
Yume27 merged 2 commits intodevelopfrom
feature/285-example-script-on-how-to-simulate-faults
Jul 2, 2025
Merged

Feature/285 example script on how to simulate faults#286
Yume27 merged 2 commits intodevelopfrom
feature/285-example-script-on-how-to-simulate-faults

Conversation

@Yume27
Copy link
Copy Markdown
Contributor

@Yume27 Yume27 commented Jun 21, 2025

Description

Closes #285

Includes an example script on how to model faults with four reaction wheels.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New example script.

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

N/A

Future Work

N/A

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copilot AI review requested due to automatic review settings June 21, 2025 01:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new fault modeling example script that demonstrates simulating faults with four reaction wheels.

  • Registers fault_environment in the examples toctree
  • Notes the new example in the release notes

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
examples/_default.rst Added fault_environment to the examples list
docs/source/release_notes.rst Documented the new fault modeling example
Comments suppressed due to low confidence (1)

docs/source/release_notes.rst:43

  • Indent this bullet to match existing entries so the asterisk aligns (add a leading space before *).
* Add fault modeling example script using four reaction wheels in the `Fault Environment <examples/fault_environment.ipynb>`_ example.

@Yume27 Yume27 force-pushed the feature/285-example-script-on-how-to-simulate-faults branch 5 times, most recently from a6aacc3 to 19e6db2 Compare June 27, 2025 02:18
Copy link
Copy Markdown
Contributor

@Mark2000 Mark2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but have a few suggestions I commented below!

@Yume27 Yume27 force-pushed the feature/285-example-script-on-how-to-simulate-faults branch 2 times, most recently from 25ff7ad to 7dda3a0 Compare June 30, 2025 18:23
@Yume27 Yume27 force-pushed the feature/285-example-script-on-how-to-simulate-faults branch from 7dda3a0 to 8900fe0 Compare June 30, 2025 23:58
@Mark2000 Mark2000 self-requested a review July 1, 2025 23:17
Copy link
Copy Markdown
Contributor

@Mark2000 Mark2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes, looks good.

@Yume27 Yume27 merged commit ecc18ff into develop Jul 2, 2025
5 checks passed
@Yume27 Yume27 deleted the feature/285-example-script-on-how-to-simulate-faults branch July 2, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example script on how to simulate faults

3 participants