Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a mechanism to skip initial logging during environment resets to prevent unwanted log entries on the first reset. The implementation uses a counter that decrements on each reset until reaching zero, after which normal logging resumes.
- Introduces a
logs_to_skipcounter initialized to 3 to suppress logging on initial resets - Modifies the
reset()method to conditionally calllog_data_on_reset()based on the counter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
66c5f96 to
759935c
Compare
Yume27
reviewed
Nov 19, 2025
Contributor
Yume27
left a comment
There was a problem hiding this comment.
Do you have any reason why you chose 3 for that?
Contributor
Author
|
Trial and error. Tried to find a more robust way of telling |
Yume27
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RLlib logging wrapper logs some weird data immediately after starting RLlib. This code avoids those logs. I don't love this code, but it's better than nothing.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
RLlib code not covered by tests.
Future Work
None.
Checklist