Ports -- Kate #45
Ports -- Kate #45
Conversation
styles/style.css
Outdated
| list-style: none; | ||
| } | ||
|
|
||
| [placeholder]:focus::-webkit-input-placeholder { |
|
|
||
| <section> | ||
| <h1>Startrly</h1> | ||
| <nav class="navbar"> |
There was a problem hiding this comment.
All your sectioning attributes could probably be IDs instead of classes, since they're only being used once, but that's just a stylistic thing.
| <ul> | ||
| <li> | ||
| <ul class="answers"> | ||
| <li class="answerbox"> |
There was a problem hiding this comment.
Instead of giving the li elements class attributes, could you leave them as-is and just refer to them in the css as belonging to their parent ul? Like .answers li would cover all the list items inside the .answers ul.
styles/style.css
Outdated
| margin: 0; | ||
| color:#43485c; | ||
| font-size: 20px; | ||
| font-family: 'IBM Plex Sans', sans-serif; |
There was a problem hiding this comment.
I'm not sure whether you need to redefine the font-family, since you already did that in the body rule-set.
styles/style.css
Outdated
| transition: 0.3s linear; | ||
| } | ||
|
|
||
| .nav li:not(:first-child)not(:last-child){ |
There was a problem hiding this comment.
Ooh, I like this way of getting at the middle element of the nav.
| width: 100%; | ||
| } | ||
|
|
||
| .welcome a[href] { |
There was a problem hiding this comment.
Does this selector do anything other than select the a element? All the a elements have href attributes.
|
|
||
| .team { | ||
| display: grid; | ||
| grid-template: repeat(2, 1fr) / repeat(5, minmax(10px, 1fr)); |
There was a problem hiding this comment.
I don't know what minmax is but it seems pretty hot
2 participants
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions