Skip to content

Ports -- Kate #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
goblineer wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ports -- Kate #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
691152a
lays out page with stylesheet
goblineer Apr 5, 2019
48ab471
Messes around with navbar, doesn't fix it.
goblineer Apr 5, 2019
3ab66e1
Changes some styles
goblineer Apr 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added images/bananas.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/congruent_pentagon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/fern.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/pink_rice.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/wavy-dots.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
65 changes: 32 additions & 33 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,34 +3,34 @@
<head>
<meta charset="utf-8">
<title>Startrly</title>
<link rel="stylesheet" href="styles/normalize.css">
<link rel="stylesheet" href="styles/style.css">
</head>
<body>
<div>


<nav>
<ul>
<li>
Startrly
</li>
<li>
Try Now!
</li>
<li>
About
</li>
</ul>
</nav>


<section>
<h1>Startrly</h1>
<body>
<nav class="navbar">
Copy link

@kanderson38 kanderson38 Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All your sectioning attributes could probably be IDs instead of classes, since they're only being used once, but that's just a stylistic thing.

<ul class="nav">
<li class="navbar-name"><a href="#">
Startrly</a>
</li>
<li class="hacky">🦒</li>
<li class="action"><a href="#">
Try Now!</a>
</li>
<li><a href="#">
About</a>
</li>
</ul>
</nav>

<section class="welcome">
<header><h1>Startrly</h1></header>
<sub>A catchy tagline for a great solution</sub>
<a href="#">Some Call to Action</a>
</section>


<section>
<section class="quote">
<blockquote>
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
</blockquote>
Expand All @@ -40,24 +40,24 @@ <h1>Startrly</h1>
</section>


<section>
<section class="why">
<h2>Why?</h2>
<ul>
<li>
<ul class="answers">
<li class="answerbox">
Copy link

@kanderson38 kanderson38 Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of giving the li elements class attributes, could you leave them as-is and just refer to them in the css as belonging to their parent ul? Like .answers li would cover all the list items inside the .answers ul.

<img src="http://via.placeholder.com/100x100" />
<strong>Comfortable</strong>
<p>
Et quas molestias excepturi sint occaecati cupiditate non providents, ut aut reiciendis voluptatibus maiores.
</p>
</li>
<li>
<li class="answerbox">
<img src="http://via.placeholder.com/100x100" />
<strong>Robust</strong>
<p>
At vero eos et accusamus et iusto odio dignissimos ducimus qui. Quis autem vel eum iure reprehenderit qui in ea voluptate velit esse quam.
</p>
</li>
<li>
<li class="answerbox">
<img src="http://via.placeholder.com/100x100" />
<strong>Convenient</strong>
<p>
Expand All @@ -68,7 +68,7 @@ <h2>Why?</h2>
</section>


<section>
<section class="quote">
<blockquote>
Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt.
</blockquote>
Expand All @@ -80,7 +80,7 @@ <h2>Why?</h2>

<section>
<h2>Meet the team</h2>
<ul>
<ul class="team">
<li>
<img src="https://placebear.com/150/150" alt="profile for kari kiwi" />
<span>Kari Kiwi</span>
Expand Down Expand Up @@ -110,9 +110,9 @@ <h2>Meet the team</h2>
</section>


<section>
<section class="sponsorlist">
<h2>Sponsors</h2>
<ul>
<ul class="sponsors">
<li>
<img src="http://via.placeholder.com/300x100" />
</li>
Expand All @@ -132,7 +132,7 @@ <h2>Sponsors</h2>
</section>


<section>
<section id="footer">
<div>
<h3>Support</h3>
<ul>
Expand Down Expand Up @@ -165,7 +165,6 @@ <h3>About</h3>
</ul>
</div>
</section>

</div>
</body>
</html>

Loading