Breakout Room 10 - Implementing Mad Libs Generator #11
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,23 @@ | ||
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
| while (loop < 9): | ||
|
Collaborator
There was a problem hiding this comment. Double check the exit condition for while loop and make sure user can create 10 stories. |
||
| // All the questions that the program asks the user | ||
| noun = input("Choose a noun: ") | ||
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") | ||
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") | ||
|
Comment on lines
+6
to
+11
Collaborator
There was a problem hiding this comment. Consider if users enter an invalid input, such as empty input, noun instead of plural noun, a noun instead of adjective.. How would the code handle situations like that? |
||
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") | ||
|
Collaborator
There was a problem hiding this comment. Double check the spelling "seond_noun" (possible typo) |
||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () | ||
|
Collaborator
There was a problem hiding this comment. Consider removing this line if print() has no contents? |
||
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
|
Collaborator
There was a problem hiding this comment. Consider using f string for integrating variables with strings and adding spaces between words. |
||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" | ||
| loop = loop + 1 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 2, 5, 12, 22: consider using # for comments instead of “//”