Carlos Estrada exercise 1 - #11
Open
Loptt wants to merge 5 commits into
Open
Conversation
AlexHenkel
requested changes
May 14, 2018
AlexHenkel
left a comment
AlexHenkel
left a comment
Owner
There was a problem hiding this comment.
This looks great! Few comments to add, it really shows your skills in terms of coding HTML and also UI/UX
| </div> | ||
| </div> | ||
| <div class="row"> | ||
| <div class="col-sm-12"> |
Owner
There was a problem hiding this comment.
When you have multiple items as columns that belong to the same section (like here, where each column is a photo of the gallery) just use 1 <div class="row"> to contain all those items, unless you have a good reason to not do so.
Look what happens now at my resolution. This will be fixed if you put all the photo columns in the same row
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my delivery for the first exercise. Any comment would be appreciated. :)