API Review Process: Add ADO Work Item metadata and assign architects to Review PRs at creation time#47534
Conversation
There was a problem hiding this comment.
⚠️ Not ready to approve
The workflow currently makes azsdk a hard prerequisite even when work item metadata is optional and uses fnmatch semantics that can diverge from CODEOWNERS-style matching, potentially requesting incorrect reviewers.
Pull request overview
This PR enhances the API review PR creation workflow by (a) enriching the PR body sync metadata with the related ADO package work item ID and (b) automatically requesting API architecture reviewers based on a new .github/ARCHITECTS ownership map.
Changes:
- Adds
azsdk package find-work-itemintegration to capture and persistpackageWorkItemIdin the hidden PR metadata block. - Introduces
.github/ARCHITECTS(CODEOWNERS-like) and requests matching GitHub users as reviewers when the API review PR is created/reused. - Expands unit tests to cover azsdk lookup, ARCHITECTS resolution, and reviewer assignment behaviors.
File summaries
| File | Description |
|---|---|
| scripts/api_md_workflow/create_api_review_pr.py | Adds azsdk work item lookup, ARCHITECTS parsing, and GitHub reviewer-request logic. |
| scripts/api_md_workflow/create_api_review_pr_test.py | Adds coverage for new work item and architect assignment behavior. |
| .github/skills/create-api-review-pr/SKILL.md | Updates skill prerequisites/flow to account for azsdk-driven work item lookup. |
| .github/ARCHITECTS | Adds CODEOWNERS-style mapping for API architecture reviewer assignment. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 5
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
There was a problem hiding this comment.
⚠️ Not ready to approve
Several newly added unit tests assert outdated package_work_item_id() return values/messages that no longer match the implementation and will fail.
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 8
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
This PR does two main things:
Retrieves the ADO Package Work Item at the time of Review PR creation and stores it in the PR metadata block. This will be used by future phases.
Adds an ARCHITECTS file to
.githubthat functions like CODEOWNERS (same format) but is only used for assigning reviews on API Review PRs.