-
Notifications
You must be signed in to change notification settings - Fork 3.3k
API Review Process: Add ADO Work Item metadata and assign architects to Review PRs at creation time #47534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
API Review Process: Add ADO Work Item metadata and assign architects to Review PRs at creation time #47534
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ed4efb4
Add ADO work item metadata to review PR creation.
tjprescott 391e671
Add ARCHITECTS file that works like CODEOWNERS but only for review PRs.
tjprescott f7feb6d
Code review feedback.
tjprescott c9abdb9
Update unit tests.
tjprescott 0ba5238
Code review feedback.
tjprescott 34c4fbf
Fix cspell
tjprescott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Instructions for ARCHITECTS file format: | ||
| # This file follows the CODEOWNERS pattern style. Each non-comment line maps a | ||
| # repository path pattern to the GitHub user or team responsible for API architecture review. | ||
| # Owners may be individual users like @octocat or teams like @Azure/sdk-arch. | ||
|
|
||
| ########### | ||
| # SDK | ||
| ########### | ||
|
|
||
| # Catch all | ||
| /sdk/ @kashifkhan | ||
|
tjprescott marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -363,6 +363,7 @@ | |
| "oauthlib", | ||
| "objs", | ||
| "odata", | ||
| "octocat", | ||
| "oidc", | ||
| "onboarded", | ||
| "onmicrosoft", | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.