Skip to content

Upgrade BinSkim from deprecated v1.9.5 to v4.3.1 in 1ES SDL config#47981

Closed
simorenoh wants to merge 1 commit into
mainfrom
simorenoh/upgrade-binskim-4-3-1
Closed

Upgrade BinSkim from deprecated v1.9.5 to v4.3.1 in 1ES SDL config#47981
simorenoh wants to merge 1 commit into
mainfrom
simorenoh/upgrade-binskim-4-3-1

Conversation

@simorenoh

Copy link
Copy Markdown
Member

Summary

1ES Pipeline Templates inject BinSkim as part of SDL Binary Analysis. 1ES PT auto-upgraded BinSkim from v1.9.5 to v4.3.1 only for pipelines with auto-baselining enabled. Our sdl config in eng/pipelines/templates/stages/1es-redirect.yml sets featureFlags.autoBaseline: false for every pipeline except python - core, so the automatic upgrade never applied and those pipelines still surface the non-blocking S360 warning:

1ES PT Non-Blocking Error: This pipeline is using the deprecated BinSkim v1.9.5 which will be retired and upgraded to the latest version.

Why v4.3.1

Per the 1ES guidance (https://aka.ms/1espt/binskim195): v1.9.5 bundles a vulnerable msdia140.dll (malicious PDBs could attack BinSkim users). v4.3.1 fixes this and adds features such as scanning DLLs with embedded PDBs.

Change

Adds the recommended manual override to the shared sdl: block:

sdl:
  binskim:
    preReleaseVersion: '4.3.1'

This works for both Official and Unofficial 1ES templates and applies repo-wide.

Notes

  • If BinSkim v4.3.1 surfaces new findings, manual rebaselining will be required (download new baselines and check in). Unlikely for this repo since it ships no compiled binaries of its own.
  • Flagging for eng-sys / 1ES owners to review — this is a repo-wide pipeline config change.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

1ES PT injects BinSkim v1.9.5 for pipelines that have auto-baselining disabled (all Python pipelines except 'python - core'). v1.9.5 is deprecated and ships a vulnerable msdia140.dll. Set the manual override to upgrade to v4.3.1 as recommended by 1ES.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simorenoh simorenoh closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant