Upgrade BinSkim from deprecated v1.9.5 to v4.3.1 in 1ES SDL config#47981
Closed
simorenoh wants to merge 1 commit into
Closed
Upgrade BinSkim from deprecated v1.9.5 to v4.3.1 in 1ES SDL config#47981simorenoh wants to merge 1 commit into
simorenoh wants to merge 1 commit into
Conversation
1ES PT injects BinSkim v1.9.5 for pipelines that have auto-baselining disabled (all Python pipelines except 'python - core'). v1.9.5 is deprecated and ships a vulnerable msdia140.dll. Set the manual override to upgrade to v4.3.1 as recommended by 1ES. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1ES Pipeline Templates inject BinSkim as part of SDL Binary Analysis. 1ES PT auto-upgraded BinSkim from v1.9.5 to v4.3.1 only for pipelines with auto-baselining enabled. Our
sdlconfig ineng/pipelines/templates/stages/1es-redirect.ymlsetsfeatureFlags.autoBaseline: falsefor every pipeline exceptpython - core, so the automatic upgrade never applied and those pipelines still surface the non-blocking S360 warning:Why v4.3.1
Per the 1ES guidance (https://aka.ms/1espt/binskim195): v1.9.5 bundles a vulnerable
msdia140.dll(malicious PDBs could attack BinSkim users). v4.3.1 fixes this and adds features such as scanning DLLs with embedded PDBs.Change
Adds the recommended manual override to the shared
sdl:block:This works for both Official and Unofficial 1ES templates and applies repo-wide.
Notes
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com