Skip to content

Upgrade BinSkim from deprecated v1.9.5 to v4.3.1 in 1ES SDL config #47981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simorenoh wants to merge 1 commit into from
Closed

Upgrade BinSkim from deprecated v1.9.5 to v4.3.1 in 1ES SDL config #47981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions eng/pipelines/templates/stages/1es-redirect.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ extends:
os: windows
# Turn off the build warnings caused by disabling some sdl checks
createAdoIssuesForJustificationsForDisablement: false
# Upgrade BinSkim from the deprecated v1.9.5 to v4.3.1. The automatic
# upgrade only applies to pipelines with auto-baselining enabled, which is
# disabled here for everything except 'python - core', so set it manually.
binskim:
preReleaseVersion: '4.3.1'
eslint:
enabled: false
justificationForDisabling: "ESLint injected task has failures because it uses an old version of mkdirp. We should not fail for tools not controlled by the repo. See: https://dev.azure.com/azur 19 e-sdk/internal/_build/results?buildId=3556850"
Expand Down
Loading