Skip to content

Fix/deploy#42

Open
dannda wants to merge 2 commits intodevfrom
fix/deploy
Open

Fix/deploy#42
dannda wants to merge 2 commits intodevfrom
fix/deploy

Conversation

@dannda
Copy link
Collaborator

@dannda dannda commented Jan 20, 2026

Description

add install to build step and output dev build to dist/dev

Type of change

  • 🐛 Bug fix (non-breaking change that resolves an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • ⚡ Optimisation (non-breaking improvement to performance or efficiency)
  • 🧩 Documentation (adds or improves documentation)
  • 🧱 Maintenance (refactor, dependency update, CI/CD, etc.)
  • 🔥 Breaking change (fix or feature that causes existing functionality to change)

Checklist

  • All tests pass (eg. npm test)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)
  • Documentation updated (if required)

Copilot AI review requested due to automatic review settings January 20, 2026 11:32
@netlify
Copy link

netlify bot commented Jan 20, 2026

Deploy Preview for biongff-vizarr ready!

Name Link
🔨 Latest commit b634a1f
🔍 Latest deploy log https://app.netlify.com/projects/biongff-vizarr/deploys/696f67cec44f5d00088138ab
😎 Deploy Preview https://deploy-preview-42--biongff-vizarr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request attempts to fix deployment issues by adding dependency installation steps before builds and configuring the dev build to output to a separate dist/dev directory, with the .nojekyll file creation moved to a dedicated step.

Changes:

  • Added pnpm i before each build command to ensure branch-specific dependencies are installed
  • Added --outDir dist/dev flag to the dev build command to separate dev and main build outputs
  • Moved .nojekyll file creation to a separate step after both builds complete

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

echo "Building dev branch output..."
pnpm build
touch sites/app/dist/.nojekyll
pnpm i && pnpm build --outDir dist/dev
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --outDir dist/dev flag is being passed to pnpm build, but this won't work as expected. The root pnpm build script runs pnpm build:viewer && pnpm build:app, which eventually calls vite build. The --outDir flag needs to be passed through to the vite command, not to the pnpm script.

You have a few options to fix this:

  1. Modify the sites/app/vite.config.js to use an environment variable for the output directory
  2. Use a different build script in sites/app/package.json specifically for dev builds
  3. Pass the flag differently through the pnpm command chain

Without this fix, the dev build will output to the default location (sites/app/dist), not to sites/app/dist/dev.

Suggested change
pnpm i && pnpm build --outDir dist/dev
pnpm i && pnpm build -- --outDir dist/dev

Copilot uses AI. Check for mistakes.
echo "Building dev branch output..."
pnpm build
touch sites/app/dist/.nojekyll
pnpm i && pnpm build --outDir dist/dev
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .nojekyll file is now being created after both builds complete, which creates a problem. Since the dev build is supposed to output to dist/dev, but .nojekyll is being created at sites/app/dist/.nojekyll (the root of the dist folder), this doesn't correctly handle both build outputs.

If the intention is to have both main and dev builds in the same dist folder (main at the root and dev in a subdirectory), you need to ensure that:

  1. The main build outputs to sites/app/dist
  2. The dev build outputs to sites/app/dist/dev
  3. The .nojekyll file is created at sites/app/dist/.nojekyll (which it is)

However, this requires the dev build to actually use the correct output directory (see previous comment about --outDir not working as expected).

Suggested change
pnpm i && pnpm build --outDir dist/dev
pnpm i && pnpm build --outDir sites/app/dist/dev

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant