Skip to content

Fix/deploy #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dannda wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix/deploy #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b98cc8
fix: add install to deploy workflow and output dev to dist/dev
dannda Jan 20, 2026
b634a1f
add name to .nojekyll step
dannda Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,17 @@ jobs:
git fetch origin main
git checkout main
echo "Building main branch output..."
pnpm build
pnpm i && pnpm build

- name: Build dev branch
run: |
git fetch origin dev
git checkout dev
echo "Building dev branch output..."
pnpm build
touch sites/app/dist/.nojekyll
pnpm i && pnpm build --outDir dist/dev
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --outDir dist/dev flag is being passed to pnpm build, but this won't work as expected. The root pnpm build script runs pnpm build:viewer && pnpm build:app, which eventually calls vite build. The --outDir flag needs to be passed through to the vite command, not to the pnpm script.

You have a few options to fix this:

  1. Modify the sites/app/vite.config.js to use an environment variable for the output directory
  2. Use a different build script in sites/app/package.json specifically for dev builds
  3. Pass the flag differently through the pnpm command chain

Without this fix, the dev build will output to the default location (sites/app/dist), not to sites/app/dist/dev.

Suggested change
pnpm i && pnpm build --outDir dist/dev
pnpm i && pnpm build -- --outDir dist/dev

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .nojekyll file is now being created after both builds complete, which creates a problem. Since the dev build is supposed to output to dist/dev, but .nojekyll is being created at sites/app/dist/.nojekyll (the root of the dist folder), this doesn't correctly handle both build outputs.

If the intention is to have both main and dev builds in the same dist folder (main at the root and dev in a subdirectory), you need to ensure that:

  1. The main build outputs to sites/app/dist
  2. The dev build outputs to sites/app/dist/dev
  3. The .nojekyll file is created at sites/app/dist/.nojekyll (which it is)

However, this requires the dev build to actually use the correct output directory (see previous comment about --outDir not working as expected).

Suggested change
pnpm i && pnpm build --outDir dist/dev
pnpm i && pnpm build --outDir sites/app/dist/dev

Copilot uses AI. Check for mistakes.

- name: Add .nojekyll
run: touch sites/app/dist/.nojekyll

- name: Upload build output
uses: actions/upload-pages-artifact@v3
Expand Down