Skip to content

fix(BUY-64574): pass placeholder contrast on home and results #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BuyWhere wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(BUY-64574): pass placeholder contrast on home and results #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d862be7
fix(BUY-64574): bump placeholder to white/95 to pass WCAG AA on indig…
claude Jul 29, 2026
043bb03
fix(BUY-64574): raise results search placeholder contrast
claude Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/app/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,19 @@ body {
}
}

/* Search input placeholder — WCAG AA contrast on dark indigo hero background */
/* Search input placeholder — WCAG AA contrast on indigo-600→indigo-900 gradient.
* placeholder-white/95 (and InheritedTailwind .placeholder-white/95) gives >=4.5:1
* contrast once alpha-composited over the bg-white/10 field tint. The previously
* shipped 0.85 white failed AA on the lightest gradient edge (indigo-600 ≈ 4.21:1).
*/
.search-input::placeholder {
color: rgba(255, 255, 255, 0.85);
color: rgba(255, 255, 255, 0.95);
}

.search-input::-webkit-input-placeholder {
color: rgba(255, 255, 255, 0.85);
color: rgba(255, 255, 255, 0.95);
}

.search-input::-moz-placeholder {
color: rgba(255, 255, 255, 0.85);
color: rgba(255, 255, 255, 0.95);
}
2 changes: 1 addition & 1 deletion src/app/search/SearchResultsClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,7 @@ export default function SearchResultsClient({
}
}}
placeholder="Search sneakers, laptops, espresso machines..."
className="h-14 w-full rounded-2xl border border-slate-200 bg-white pl-12 pr-4 text-base text-slate-900 shadow-sm outline-none transition focus:border-amber-400 focus:ring-4 focus:ring-amber-100"
className="h-14 w-full rounded-2xl border border-slate-200 bg-white pl-12 pr-4 text-base text-slate-900 placeholder:text-slate-600 shadow-sm outline-none transition focus:border-amber-400 focus:ring-4 focus:ring-amber-100"
aria-label="Search products"
role="combobox"
aria-autocomplete="list"
Expand Down
2 changes: 1 addition & 1 deletion src/components/HomeProductSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export function HomeProductSearch() {
}
}}
placeholder="Search products..."
className="search-input w-full rounded-xl border-2 border-white/20 bg-white/10 py-5 pl-14 pr-4 text-lg text-white placeholder-white/85 transition-all focus:border-white focus:bg-white/20 focus:outline-none focus:ring-4 focus:ring-white/20"
className="search-input w-full rounded-xl border-2 border-white/20 bg-white/10 py-5 pl-14 pr-4 text-lg text-white placeholder-white/95 transition-all focus:border-white focus:bg-white/20 focus:outline-none focus:ring-4 focus:ring-white/20"
aria-label="Search products"
aria-invalid={Boolean(error)}
aria-describedby={error ? errorId : undefined}
Expand Down