Skip to content

Improve C3T3 IO#5151

Open
maxGimeno wants to merge 19 commits intoCGAL:mainfrom
maxGimeno:C3t3-Better_IO-maxGimeno
Open

Improve C3T3 IO#5151
maxGimeno wants to merge 19 commits intoCGAL:mainfrom
maxGimeno:C3t3-Better_IO-maxGimeno

Conversation

@maxGimeno
Copy link
Contributor

@maxGimeno maxGimeno commented Nov 9, 2020

Summary of Changes

Save/load edges in complex in c3t3 operator<</>>

Release Management

TODO

@MaelRL MaelRL changed the title C3t3 better io max gimeno Improve C3T3 IO Nov 10, 2020
@maxGimeno maxGimeno force-pushed the C3t3-Better_IO-maxGimeno branch from 46c04c1 to e70650e Compare November 13, 2020 14:27
@maxGimeno maxGimeno force-pushed the C3t3-Better_IO-maxGimeno branch from e70650e to aca4841 Compare November 16, 2020 08:23
@MaelRL MaelRL added this to the 5.3-beta milestone Dec 2, 2020
@maxGimeno maxGimeno marked this pull request as ready for review February 8, 2021 09:25
@maxGimeno maxGimeno self-assigned this Feb 8, 2021
@sloriot
Copy link
Member

sloriot commented Sep 23, 2021

@lrineau should this PR be closed?

@lrineau lrineau removed the TODO label Sep 23, 2021
@lrineau lrineau modified the milestones: 5.4-beta, 5.5-beta1 Sep 23, 2021
@lrineau lrineau removed the Conflicts label Sep 23, 2021
@lrineau
Copy link
Member

lrineau commented Sep 23, 2021

@lrineau should this PR be closed?

No. Now that we have abandoned #5145, this PR seems the right thing to do.

@lrineau lrineau assigned lrineau and unassigned maxGimeno Sep 23, 2021
@janetournois
Copy link
Member

janetournois commented Jan 7, 2022

@sloriot is this what you meant?
The assertion added in commit f11cc0f fails
I am checking why

@janetournois
Copy link
Member

janetournois commented Jan 7, 2022

It fails because c3t3 (to be written) is output with its complex edges, so this is added to the end of the dump :

2
1 3 5
1 4 6

though c3t3_2 (loaded from the dump of c3t3) does not have complex edges, they have not been loaded.

@sloriot sloriot modified the milestones: 5.5-beta, 5.6-beta Apr 12, 2022
@MaelRL MaelRL modified the milestones: 5.6-beta, 5.7-beta Mar 31, 2023
@janetournois janetournois modified the milestones: 6.0-beta, 6.1-beta May 16, 2024
@MaelRL MaelRL modified the milestones: 6.1-beta, 6.2-beta Mar 17, 2025
@sloriot sloriot changed the base branch from master to main September 16, 2025 19:20
@sloriot
Copy link
Member

sloriot commented Jan 9, 2026

#7821 mentioned that it is similar. Shall we close this PR? @ange-clement @janetournois

@janetournois
Copy link
Member

they are similar and follow the same target, but for now they are complementary and should be "merged" (if I'm right, #7821 does not contain the "write" code for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mesh_3: Save/load c3t3 objects correctly

5 participants