Skip to content

Mesh 3 - Triangulation IO and Save and load C3t3 features#7821

Open
ange-clement wants to merge 20 commits intoCGAL:mainfrom
ange-clement:Mesh-3-IO-preserve-features-aclement
Open

Mesh 3 - Triangulation IO and Save and load C3t3 features#7821
ange-clement wants to merge 20 commits intoCGAL:mainfrom
ange-clement:Mesh-3-IO-preserve-features-aclement

Conversation

@ange-clement
Copy link
Member

@ange-clement ange-clement commented Oct 23, 2023

Summary of Changes

Enable writing and reading of 1D features (edges) of Mesh_complex_3_in_triangulation_3.
The Triangulation_3 writing and loading have been moved to CGAL::IO::export_triangulation_3 and CGAL::IO::import_triangulation_3

Tasks:

  • Move Triangulation_3 writing and loading (operator<</>>)
  • Make Triangulation_3::file_input use the writing and loading (remove duplicated code)
  • Add 1D features to polyhedron demo

Release Management

@janetournois janetournois added this to the 6.0-beta milestone Oct 24, 2023
@ange-clement ange-clement marked this pull request as ready for review October 26, 2023 12:59
@lrineau lrineau self-requested a review October 30, 2023 14:41
@lrineau lrineau linked an issue Oct 30, 2023 that may be closed by this pull request
Copy link
Member

@lrineau lrineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment, the testsuite of Triangulation_3 fails. I tried on my machine:

ctest --test-dir build/RelWithDebInfo -L Triangulation_3 -j12

and the results was:

82% tests passed, 16 tests failed out of 89

Label Time Summary:
CGAL_build_system           =  24.20 sec*proc (2 tests)
Triangulation_3_Demo        =  20.06 sec*proc (1 test)
Triangulation_3_Examples    = 317.92 sec*proc (42 tests)
Triangulation_3_Tests       = 366.77 sec*proc (44 tests)

Total Test time (real) =  89.57 sec

The following tests FAILED:
        2134 - compilation of  simple_triangulation_3 (Failed)
        2135 - execution   of  simple_triangulation_3 (Not Run)
        5041 - compilation of  test_delaunay_3 (Failed)
        5042 - execution   of  test_delaunay_3 (Not Run)
        5045 - compilation of  test_delaunay_hierarchy_3 (Failed)
        5046 - execution   of  test_delaunay_hierarchy_3 (Not Run)
        5047 - compilation of  test_delaunay_hierarchy_3_old (Failed)
        5048 - execution   of  test_delaunay_hierarchy_3_old (Not Run)
        5051 - compilation of  test_regular_as_delaunay_3 (Failed)
        5052 - execution   of  test_regular_as_delaunay_3 (Not Run)
        5073 - compilation of  test_triangulation_3 (Failed)
        5074 - execution   of  test_triangulation_3 (Not Run)
        5075 - compilation of  test_io_triangulation_3 (Failed)
        5076 - execution   of  test_io_triangulation_3 (Not Run)
        5077 - compilation of  test_triangulation_serialization_3 (Failed)
        5078 - execution   of  test_triangulation_serialization_3 (Not Run)

See our wiki documentation on CTest.

@sloriot sloriot added the Batch_1 First Batch of PRs under testing label Oct 31, 2023
@ange-clement ange-clement marked this pull request as draft November 2, 2023 08:24
@sloriot sloriot added Under Testing and removed Batch_1 First Batch of PRs under testing labels Nov 2, 2023
@sloriot sloriot added Tests failing Batch_1 First Batch of PRs under testing and removed Under Testing labels Nov 2, 2023
@ange-clement ange-clement marked this pull request as ready for review November 7, 2023 16:09
@ange-clement
Copy link
Member Author

@lrineau @janetournois This PR is ready to be reviewed.

@sloriot sloriot removed the Batch_1 First Batch of PRs under testing label Nov 29, 2023
@sloriot
Copy link
Member

sloriot commented Feb 21, 2024

@sloriot
Copy link
Member

sloriot commented Aug 13, 2024

Test failing in 6.0-Ic-305

See here

@MaelRL MaelRL modified the milestones: 6.1-beta, 6.0.2, 6.2-beta Mar 19, 2025
@sloriot sloriot changed the base branch from master to main September 18, 2025 05:56
@sloriot sloriot mentioned this pull request Jan 9, 2026
@janetournois janetournois force-pushed the Mesh-3-IO-preserve-features-aclement branch from 36f836d to 6fe422c Compare March 3, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save and load complex edges of a C3T3 to/from the CGAL binary format Mesh_3: Save/load c3t3 objects correctly

6 participants