Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECON D CRC (trailer) computation in the Unpacker #165

Open
wants to merge 7 commits into
base: CMSSW_15_0_0_pre2
Choose a base branch
from
Open

ECON D CRC (trailer) computation in the Unpacker #165

wants to merge 7 commits into from

Conversation

cramonal
Copy link

PR description:

  • This PR implements the CRC computation for the ECOND trailer at the Unpacker level. This was previously done during the DQM step (hgcal commissioning tools).
  • Changes the cbFlag to be 16bits and the first bit is activated when there is a CRC error in the ECOND trailer.
  • Associated MR in hgcal commissioning tools 83. This removes the part of code in the DQM that is now done in the unpacker.

PR validation:

  • The basic test procedure suggested in the CMSSW PR instructions
  • Some runtests use-ibeos failed, those are not related to changes implemented in this PR (CalibTracker and Alignment). This is expected.
  • Desired output when running the raw to digi step with the HGCAL config.

@pfs
Copy link

pfs commented Feb 5, 2025

ready to push to CMSSW directly

pfs
pfs reviewed Feb 5, 2025
View reviewed changes
EventFilter/HGCalRawToDigi/src/Unpackertools.cc Outdated
auto array = &(crcvec[0]);
auto bytes = reinterpret_cast<const unsigned char *>(array);
auto crc32 = boost::crc<32, 0x4c11db7, 0x0, 0x0, false, false>(bytes, (payloadLength - 1) * 4);
//std::cout << " crc32 = " << crc32 << " target=" << target << std::endl;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just remove this comment before making the PR to CMS

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@cramonal cramonal mentioned this pull request Feb 5, 2025
Closed
@cramonal
Copy link
Author

cramonal commented Feb 5, 2025 •
edited
Loading

PR to CMSSW:
cms-sw#47276

@cramonal cramonal mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfs pfs pfs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cramonal @pfs