Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HGCAL: ECON D CRC (trailer) computation in the Unpacker #47274

Closed
wants to merge 18 commits into from
Closed

HGCAL: ECON D CRC (trailer) computation in the Unpacker #47274

wants to merge 18 commits into from

Conversation

cramonal
Copy link

@cramonal cramonal commented Feb 5, 2025

PR description:

  • This PR implements the CRC computation for the ECOND trailer at the Unpacker level in the HGCAL code. This was previously done during the DQM step (hgcal commissioning tools).
  • Changes the cbFlag to be 16bits and the first bit is activated when there is a CRC error in the ECOND trailer.
  • Associated PR to the HGCAL fork 165
  • Associated MR in hgcal commissioning tools 83. This removes the part of code in the DQM that is now done in the unpacker.

PR validation:

  • The basic test procedure suggested in the CMSSW PR instructions
  • Some runtests use-ibeos failed, those are not related to changes implemented in this PR (CalibTracker and Alignment). This is expected.
  • Desired output when running the raw to digi step with the HGCAL config.
  • Check the time per event of the HGCal RawToDigi step:

Zero suppressed electron run

n modules without crc [ms] +/- with crc [ms] +/-
6x1 0.021917350500000002 0.00020274464675325022 0.031077092150000003 0.00013585780965978005
6x30 0.289457397975 0.00022782273192934225 0.5336531552499999 0.0014708887321899862
6x100 0.9192382436000002 0.0009976292174406984 1.7252770796999999 0.008222489283060488

pedestal run

n modules without crc +/- with crc +/-
6 0.02695821815 8.683049197253462e-05 0.056449379975 4.728613323805305e-05
6x30 0.54170733345 0.005254682285522486 1.4191067191333333 0.009876582558655712
6x100 1.935505972325 0.06436482679355053 4.722040668366667 0.031014858031377032

ywkao and others added 18 commits December 3, 2024 06:53
@ywkao
Implement TH2Poly in DQM Services for HGCal DQM
8041853
@ywkao
Apply changes from code quality checks
419cb6f
@ywkao
Add a patch based on makortel's comments
5284c46
@ywkao
Implement TH2Poly support in DQMServices
fb37861 
- Add TH2Poly support in DQMServices/Core
- Implement TH2Poly in DQMServices/Components
- Add TH2Poly support in MEtoEDMFormat.h
@ywkao
Extend DQMServices testing for TH2Poly
7d85734 
- Add TH2Poly support in FwkIO and StreamerIO
- Add TH2Poly in DQMServices/Demo/test
@ywkao
Apply code-format patch
f750a33
@ywkao
Fix IndexError in the DQM unit test for TH2Poly
cca126b
@ywkao
Fix TypeError in DQMServices/Demo/test/dqmiodumpentries.py. Omit De…
eb41648 
…precationWarning of `getattr()`.

| ROOT version | `getattr(f,"x")` | `f["x"]`    |
| ------------ | ---------------- | ----------- |
| v6.30        | works            | Not working |
| v6.35        | works*           | works       |
| v6.32        | works*           | works       |

* This will display deprecation warning message
@ywkao
Fix typo in DataFormats/Histograms/src/classes_def.xml
59617bc
@ywkao
apply code checks and format recommendation
07470c1
Merged hgcal-dqm_with_th2poly-13_2_X from repository ywkao with cms-m…
f66ce2e 
…erge-topic
Merged hgcal-dqm_with_th2poly-13_2_X from repository ywkao with cms-m…
aa81084 
…erge-topic
adding ECOND trailer CRC check in the unpacker
a642ed7
fix logDebug
7f95aec
@pfs
Merged CMSSW_15_0_0_pre2 from repository CMS-HGCAL with cms-merge-topic
a746423
@pfs
Merged myCRCdev from repository cramonal with cms-merge-topic
1a55798
@pfs
format changes
e94a858
@cramonal
remove comment
c5c5880
@cmsbuild cmsbuild changed the base branch from CMSSW_15_0_X to master February 5, 2025 17:11
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

@cramonal, CMSSW_15_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cramonal cramonal mentioned this pull request Feb 5, 2025
Closed
@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Feb 5, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47274/43581

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@pfs
Copy link
Contributor

pfs commented Feb 5, 2025

@cramonal it seems like it picked the infamous ywkao:hgcal-dqm_with_th2poly-13_2_X residuals as well...
I suggest you cancel this one, and restart a new branch fresh with the new files for the CRC check alone

@cramonal cramonal closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changes-dataformats code-checks-rejected core-pending dqm-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@cramonal @cmsbuild @pfs @ywkao