Explicitly close files to prevent resource leak#175
Merged
ryanmrichard merged 1 commit intoCMakePP:masterfrom Jan 23, 2026
Merged
Explicitly close files to prevent resource leak#175ryanmrichard merged 1 commit intoCMakePP:masterfrom
ryanmrichard merged 1 commit intoCMakePP:masterfrom
Conversation
|
|
Stephen0512
changed the title
ryanmrichard
approved these changes
Jan 23, 2026
Collaborator
ryanmrichard
left a comment
ryanmrichard
left a comment
There was a problem hiding this comment.
Thanks for the contribution! These changes look great to me.
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a file-handling issue in the tests related to redirecting
sys.stdout. The tests previously redirected output by assigningsys.stdouttoopen(os.devnull, "w")without ensuring the file handle was properly closed later on. While Python's garbage collector will eventually close the file once it is no longer referenced, it is generally better practice to explicitly close files or use a context manager.This change replaces the direct use of
open()with a context-managed approach usingcontextlib.redirect_stdout, ensuring that the file is always closed andsys.stdoutis safely restored. The behavior of the tests remains unchanged. The issue was identified during an ongoing research project.