Skip to content

Explicitly close files to prevent resource leak #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanmrichard merged 1 commit into from
Jan 23, 2026
Merged

Explicitly close files to prevent resource leak #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions tests/unit_tests/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import unittest

import context
import contextlib
import helpers

import cminx
Expand Down Expand Up @@ -48,10 +49,14 @@ def tearDown(self):

def test_document(self):
"""Tests the document command in the CMinx module"""
sys.stdout = open(os.devnull, 'w')
cminx.document(self.input_file,
Settings(InputSettings(recursive=True), OutputSettings(directory=self.output_dir)))
sys.stdout = sys.__stdout__
with open(os.devnull, "w") as devnull, contextlib.redirect_stdout(devnull):
cminx.document(
self.input_file,
Settings(
input=InputSettings(recursive=True),
output=OutputSettings(directory=self.output_dir),
),
)

# Test that the top-level directory was found
is_dir = os.path.isdir(self.output_dir)
Expand All @@ -63,11 +68,15 @@ def test_document(self):

def test_document_prefix(self):
"""Tests the document command in the CMinx module with the prefix option"""
sys.stdout = open(os.devnull, 'w')
cminx.document(self.input_file,
Settings(input=InputSettings(recursive=True), output=OutputSettings(directory=self.output_dir),
rst=RSTSettings(prefix=context.prefix)))
sys.stdout = sys.__stdout__
with open(os.devnull, "w") as devnull, contextlib.redirect_stdout(devnull):
cminx.document(
self.input_file,
Settings(
input=InputSettings(recursive=True),
output=OutputSettings(directory=self.output_dir),
rst=RSTSettings(prefix=context.prefix),
),
)

# Test that the top-level directory was found
is_dir = os.path.isdir(self.output_dir)
Expand Down