Ensure any errors in exception logging itself are logged at ERROR level #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 6 6
Lines 359 359
=======================================
Hits 329 329
Misses 30 30
Continue to review full report at Codecov.
|
brycedrennan
suggested changes
Apr 10, 2019
| record.data["error_report"] = create_exception_report(exc_type, exc_value, tb, self.output_format, self.storage_backend) | ||
| except Exception as e: | ||
| logger.warning(f"Error generating exception report {repr(e)}") # noqa | ||
| logger.error(f"Error generating exception report {repr(e)}", exc_info=True) # noqa |
There was a problem hiding this comment.
The reason to not is that this could create an infinite recursion situation. Clearly only doing a warning is great either, but this might be making things worse.
There was a problem hiding this comment.
Sorry I didn't really explain. One of the functionalities of the library is to create exception reports for error level logs so this would be calling itself.
|
What was the error that caused this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.