Skip to content

Ensure any errors in exception logging itself are logged at ERROR level #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure any errors in exception logging itself are logged at ERROR level #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exception_reports/logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def filter(self, record):
try:
record.data["error_report"] = create_exception_report(exc_type, exc_value, tb, self.output_format, self.storage_backend)
except Exception as e:
logger.warning(f"Error generating exception report {repr(e)}") # noqa
logger.error(f"Error generating exception report {repr(e)}", exc_info=True) # noqa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason to not is that this could create an infinite recursion situation. Clearly only doing a warning is great either, but this might be making things worse.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't really explain. One of the functionalities of the library is to create exception reports for error level logs so this would be calling itself.


return True

Expand Down
2 changes: 1 addition & 1 deletion exception_reports/storages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def write(self, filename, data):
return uploaded_url

except Exception:
logger.warning("Error saving exception to s3", exc_info=True)
logger.error("Error saving exception to s3", exc_info=True)


def upload_to_s3(aws_key, aws_secret, bucket, filename, contents, content_type):
Expand Down