chore: Adds the missing properties(defaults.tag and defaults.reposito…

[heitorrbarros]

By submitting a PR to this repository, you agree to the terms within the CloudZero Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Please note that changes to the cloudzero-agent Helm chart should be made instead in the helm directory in the cloudzero-agent repository, and will automatically be mirrored to this repository as soon as they are merged.

Description

On PicPay, we need to push the provider's container images to our private repository. This approach helps us conduct security scans and reduces costs associated with data transfer.

After embedding the image, I needed to point the tag and repository to our private repository. I noticed that we can apply this change by updating the values in the defaults property.

Here’s the relevant link for reference: Cloudzero Helm Chart.

After setting those values, I started encountering a schema error during the templating step. To resolve this, I created a PR to add the missing properties to the schema definition.

References

Include any links supporting this change such as a:

• GitHub Issue/PR number addressed or fixed
• StackOverflow post
• Support forum thread
• Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Inside cloudzero-agent chart run the helm template command ->

helm template test . --set existingSecretName="test-123" --set defaults.tag="test" --set defaults.repository="a"  --dry-run --debug

Output

Error: values don't meet the specifications of the schema(s) in the following chart(s):
cloudzero-agent:
- at '/defaults': additional properties 'tag', 'repository' not allowed

helm.go:92: 2025-10-27 14:46:03.140248 -0300 -03 m=+0.093139453 [debug] values don't meet the specifications of the schema(s) in the following chart(s):
cloudzero-agent:
- at '/defaults': additional properties 'tag', 'repository' not allowed

Checklist

• I have added documentation for new/changed functionality in this PR
• All active GitHub checks for tests, formatting, and security are passing
• The correct base branch is being used, if not main

[greptile-apps]

Greptile Overview

Greptile Summary

This PR adds repository and tag properties to the defaults section of the Helm values JSON schema, both typed as string | null.

Key Changes:

• Added defaults.repository property to schema definition (line 5834-5836)
• Added defaults.tag property to schema definition (line 5837-5839)
• JSON schema is syntactically valid

Analysis:
The properties appear to address schema validation requirements since defaults has additionalProperties: false. However, based on template usage patterns, these properties may be at the incorrect nesting level:

• The generateImage helper function receives .Values.defaults.image as its defaults parameter
• Within the function, it accesses .defaults.repository and .defaults.tag, which resolves to defaults.image.repository and defaults.image.tag
• These properties already exist in the com.cloudzero.agent.image schema definition referenced by defaults.image

The change doesn't introduce breaking issues but may be organizationally redundant unless there's a use case for setting these properties directly under defaults (not nested under defaults.image).

Confidence Score: 4/5

• This PR is safe to merge with minimal risk - it only adds schema validation properties
• The changes are limited to JSON schema property definitions with no logic modifications. The JSON is syntactically valid and won't break existing functionality. Score reflects a minor organizational concern about property nesting level, but this doesn't affect runtime behavior since the properties already exist in the referenced image schema.
• No files require special attention - this is a straightforward schema update

Important Files Changed

File Analysis

Filename	Score	Overview
charts/cloudzero-agent/values.schema.json	4/5	Adds repository and tag properties to defaults schema; JSON is valid but properties may be at incorrect nesting level

Sequence Diagram

sequenceDiagram
    participant User
    participant HelmSchema as values.schema.json
    participant HelmValues as values.yaml
    participant Template as _helpers.tpl
    participant Deploy as agent-deploy.yaml
    
    User->>HelmValues: Set defaults.image.repository/tag
    User->>HelmSchema: Validate values
    HelmSchema->>HelmSchema: Check defaults.repository/tag (new)
    HelmSchema->>HelmSchema: Check defaults.image properties (existing)
    HelmSchema-->>User: Validation passes
    
    Deploy->>Template: Call generateImage
    Note over Deploy,Template: Pass .Values.defaults.image as "defaults"
    Template->>Template: Access .defaults.repository
    Note over Template: Resolves to defaults.image.repository
    Template->>Template: Access .defaults.tag
    Note over Template: Resolves to defaults.image.tag
    Template-->>Deploy: Return image configuration

Loading

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: These properties may be at the incorrect nesting level. The generateImage template helper (templates/_helpers.tpl:770-789) is always called with defaults parameter set to .Values.defaults.image. This means repository and tag are accessed from the image object, where they already exist via the $ref to com.cloudzero.agent.image. Adding them directly under defaults appears redundant unless users need to set them outside of defaults.image.

Prompt To Fix With AI

This is a comment left during a code review.
Path: charts/cloudzero-agent/values.schema.json
Line: 5834:5839

Comment:
**style:** These properties may be at the incorrect nesting level. The `generateImage` template helper (templates/_helpers.tpl:770-789) is always called with `defaults` parameter set to `.Values.defaults.image`. This means `repository` and `tag` are accessed from the image object, where they already exist via the `$ref` to `com.cloudzero.agent.image`. Adding them directly under `defaults` appears redundant unless users need to set them outside of `defaults.image`.

How can I resolve this? If you propose a fix, please make it concise.

[evan-cz]

Hey @heitorrbarros, thanks for the contribution, we really appreciate it!

Unfortunately we can't actually accept it here, since the charts/cloudzero-agent directory is really just a mirror of the helm/ directory from https://github.com/Cloudzero/cloudzero-agent/tree/develop/helm, but I'm also worried this won't do what you think it would.

The reason those don't have defaults set is because all of the images we use would override those anyways. I suspect that what you really want to do is set components.agent.image.repository and components.agent.image.tag; these are the values that are used by all of the components which use our code.

Could you provide a bit more context on what you're trying to accomplish here?