Skip to content

chore: Adds the missing properties(defaults.tag and defaults.reposito… #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: Adds the missing properties(defaults.tag and defaults.reposito… #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charts/cloudzero-agent/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5831,6 +5831,12 @@
"image": {
"$ref": "#/$defs/com.cloudzero.agent.image"
},
"repository":{
"type": ["string", "null"]
},
"tag":{
"type": ["string", "null"]
},
Comment on lines +5834 to +5839
Copy link

@greptile-apps greptile-apps bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: These properties may be at the incorrect nesting level. The generateImage template helper (templates/_helpers.tpl:770-789) is always called with defaults parameter set to .Values.defaults.image. This means repository and tag are accessed from the image object, where they already exist via the $ref to com.cloudzero.agent.image. Adding them directly under defaults appears redundant unless users need to set them outside of defaults.image.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: charts/cloudzero-agent/values.schema.json
Line: 5834:5839

Comment:
**style:** These properties may be at the incorrect nesting level. The `generateImage` template helper (templates/_helpers.tpl:770-789) is always called with `defaults` parameter set to `.Values.defaults.image`. This means `repository` and `tag` are accessed from the image object, where they already exist via the `$ref` to `com.cloudzero.agent.image`. Adding them directly under `defaults` appears redundant unless users need to set them outside of `defaults.image`.

How can I resolve this? If you propose a fix, please make it concise.

"labels": {
"$ref": "#/$defs/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta/properties/labels"
},
Expand Down