Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 2 | coursework/sprint-2 #729

Alaa-Tagi · 2025-10-05T15:44:12Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have created a PR after making all the tasks required.

Questions

No questions.

jennethydyrova

Hi @Alaa-Tagi! You did a great job working on the exercises but there are several things you need to revisit.

jennethydyrova · 2025-10-13T13:41:51Z

Sprint-2/1-key-errors/0.js

 // call the function capitalise with a string input
 // interpret the error message and figure out why an error is occurring

 function capitalise(str) {


This function has another syntax error after you made some changes. Could you please fix it?

jennethydyrova · 2025-10-13T13:43:42Z

Sprint-2/1-key-errors/0.js

+// =============> write your new code here :
+/*
+function capitalise(str) {
+  let cap = `${str[0].toUpperCase()}${str.slice(1)}`;


This works well but something to consider for future is that variable names should be more descriptive, so it's easier for readers of your code to understand what this variable holds.

jennethydyrova · 2025-10-13T13:48:40Z

Sprint-2/1-key-errors/1.js

+//The correct code :
+const decimalNumber = 0.5;
+
+function convertToPercentage(decimalNumber) {


This works nicely but as an optional exercise, could you think of a way to simplify the code within this function?

jennethydyrova · 2025-10-13T13:51:23Z

Sprint-2/2-mandatory-debug/0.js

 // Predict and explain first...

-// =============> write your prediction here
+// =============> write your prediction here : There is no return statement for the parameters.


Could you please explain your prediction better? What does the no return statement for the parameters mean and how do you think it affects the function behaviour?

jennethydyrova · 2025-10-13T13:54:54Z

Sprint-2/2-mandatory-debug/0.js

 console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`);

-// =============> write your explanation here
+// =============> write your explanation here : /* The function multiply does not return any value, it only logs the result to the console. It returns undefined. To fix this, we need to add a return statement in the multiply function. */


excellent explanation!

jennethydyrova · 2025-10-13T14:07:53Z

Sprint-2/3-mandatory-implement/1-bmi.js

-    // return the BMI of someone based off their weight and height
-}
+  const bmi = weight / (height * height);
+  return bmi.toFixed(1);


This works fine but something to keep in mind is that .toFixed() would return a string. It can be okay in this case as we don't have a strict requirement for the return type but something to be careful about while using this method.

jennethydyrova · 2025-10-13T14:09:34Z

Sprint-2/3-mandatory-implement/2-cases.js

+  const upperCase = name.toUpperCase(); // Convert the string to uppercase
+  return upperCase.replaceAll(" ", "_"); // Replace all spaces with underscores
+}
+console.log(snakeItUp("alaa tagi is my name"));


Are you calling the right function here?

jennethydyrova · 2025-10-13T14:14:14Z

Sprint-2/3-mandatory-implement/3-to-pounds.js


 // You should call this function a number of times to check it works for different inputs
+
+function toPounds(penceToPound) {


Very cleanly written code with super descriptive variable names. Great job!

jennethydyrova · 2025-10-13T14:20:54Z

Sprint-2/4-mandatory-interpret/time-format.js


 // e) What is the return value assigned to num when pad is called for the last time in this program?  Explain your answer
-// =============> write your answer here
+// =============> write your answer here : "00", because num is converted to string and padded to 2 characters with "0". That's mean "1" becomes "01".


I think there is a typo in this answer, could you please double check if it's correct?

jennethydyrova · 2025-10-13T14:44:54Z

Sprint-2/5-stretch-extend/format-time.js

+); // It's output is correct
+
+//Fixing the function:
+function formatAs12HourClockFixed(time) {


The test cases you added are good but some edge cases to consider:

Passing invalid time such as "25:30" or "15:78"
2 Passing an empty string "" as parameter

Edit: I edited my comment to make it simpler for you

hi @jennethydyrova i have corrected all the things that you have mentioned earlier and push it to git .
would you please see if it correct?

Thanks

Hi @Alaa-Tagi, could you please double check if all tests are passing this file? It looks like tests are correct but they would fail.

jennethydyrova · 2025-10-24T08:10:48Z

hi @Alaa-Tagi! I think you are almost there with this PR but your formatAs12HourClockFixed still returns some interesting results when you pass:

Invalid time such as "25:30" or "15:78"
An empty string "" as parameter

Can you add assertions for these inputs and see what's missing in your function?

jennethydyrova · 2025-10-26T18:57:07Z

Great job @Alaa-Tagi!

Alaa-Tagi added 11 commits October 2, 2025 11:20

predict,explain and update the error

e3dd609

predict,explain and update the code

7f96fdf

Predict and explain the error then fix the code

4e3088e

Editing code by adding return

ce8b66d

fix the code with some explanations

0a2d800

Declare a parameter to getLastDigit

eb2af74

update BMI code

7a1579c

upper snake case

61620bc

pence To Pound

5711722

Update time-format.js

544cb83

Update format-time.js

8c774bc

Alaa-Tagi added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Oct 5, 2025

jennethydyrova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 13, 2025

jennethydyrova suggested changes Oct 13, 2025

View reviewed changes

Alaa-Tagi added 7 commits October 13, 2025 19:16

fix the code as requested

472c56d

get the code more simplified

24c915a

write addition explanation for the prediction part

812128c

rewrite bmi code

3865600

recall the right function

bfafdef

rewrite the correct answer for Q(e)

0671c48

adding another tests for the code

3b782df

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 14, 2025

Alaa-Tagi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 23, 2025

jennethydyrova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 24, 2025

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 24, 2025

Edit the code

d059399

Alaa-Tagi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 24, 2025

jennethydyrova added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025

Alaa-Tagi mentioned this pull request Oct 30, 2025

25-ITP-SEP | Structuring and testing data | Alaa Tagi Alaa-Tagi/My-Coursework-Planner#66

Open


		// You should call this function a number of times to check it works for different inputs

		function toPounds(penceToPound) {

Uh oh!

Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 2 | coursework/sprint-2 #729

Are you sure you want to change the base?

Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 2 | coursework/sprint-2 #729

Conversation

Alaa-Tagi commented Oct 5, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

jennethydyrova left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jennethydyrova Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jennethydyrova commented Oct 24, 2025

Uh oh!

jennethydyrova commented Oct 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jennethydyrova left a comment •

edited

Loading

jennethydyrova Oct 13, 2025 •

edited

Loading