Dark Matters

[ViralReaction]

Changes

Describe adjustments to existing features made in this merge, e.g.

• Darkness shooting errors only start calculating at more than 50% darkness
• Use a simple curve to calculate the error as it should get progressively harder to shoot the darker it is
• Fixes issue with lighting calculation when standing next to buildings

References

Links to the associated issues or other related pull requests, e.g.

• Closes [Bug]: Darkness Accuracy Malus has unexpected behavior #3415

Reasoning

Why did you choose to implement things this way, e.g.

• 50% light is indoor lighting inside RW.
• Even with a few lights it should not be hard to identify your target

Alternatives

Describe alternative implementations you have considered, e.g.

• Perfect Shooting

Testing

Check tests you have performed:

• Compiles without warnings
• Game runs without errors
• (For compatibility patches) ...with and without patched mod loaded
• Playtested a colony (specify how long)

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-14277197789.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-15103026382.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-15150824192.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-15174548710.zip

[Keshash]

From my testing, this is a good PR, but the added curve makes muzzle flashes way too strong at explosing the shooter. Without the curve, there was a difference between flash sizes, with it there's none.

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-15431474450.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-15864562978.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-15864633173.zip

[Breadbox2k19]

The accuracy malus at 0% brightness should still be the same, correct?

[Breadbox2k19]

From my testing, this is a good PR, but the added curve makes muzzle flashes way too strong at exposing the shooter. Without the curve, there was a difference between flash sizes, with it there's none.

If there's a way to universally halve the lighting effect of muzzle flash, that'd be great.

[Breadbox2k19]

Another thing to consider is that it could make having more 50% night vision totally worthless/ have rapidly diminishing return. Until that could be resolved, I think it's best to hold on to this for abit.

[Breadbox2k19]

May I suggest changing the curve to the following, basically the original max darkness penalty but with other issues fixed? (7 being the original max darkness penalty)

(0, 0)

(0.5, 3.5)

(1, 7)

I know for a fact that there's not going to be working backwards from big numbers since there's so many variable in CE making controlled testing a pain so barely anyone playtests for balance at all. Considering that 50% of all raids occur at night, simply making ranged weapons considerably worse during 50% of all raids is not a good balance change imo.