Skip to content

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Sep 20, 2025

Summary

Standardizes every Vue SFC so their top-level blocks line up with our new linted order, keeping structure predictable for future edits.

Changes

  • Config Added vue/block-order with ['docs', 'script', 'template', 'i18n', 'style'] so docs stay first and localization blocks remain ahead of styles.
  • Format Ran pnpm lint:fix to reorder top-level blocks across the existing Vue files; only block placement changed, no logic edits.

Review Focus

  • Double-check the ESLint rule matches our intended ordering and doesn't conflict with other lint settings.
  • Spot-check a couple of updated SFCs to confirm the diff is strictly block movement.

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne requested a review from a team as a code owner September 20, 2025 04:08
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 20, 2025
Copy link

github-actions bot commented Sep 20, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/22/2025, 04:02:32 AM UTC

📈 Summary

  • Total Tests: 459
  • Passed: 429 ✅
  • Failed: 0
  • Flaky: 1 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 422 / ❌ 0 / ⚠️ 1 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@Myestery
Copy link
Collaborator

can we add a blame ignore after this gets merged ?

@DrJKL
Copy link
Contributor

DrJKL commented Sep 22, 2025

can we add a blame ignore after this gets merged ?

I blame @christian-byrne for everything anyway 😉

Copy link
Contributor

@arjansingh arjansingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am so glad i don't have any major changes off main right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants