-
Couldn't load subscription status.
- Fork 2
feat(CI): improve readme and code coverage #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e293701 to
b872112
Compare
b872112 to
690c138
Compare
179bf1d to
0b94277
Compare
0b94277 to
e7675d8
Compare
9f9085a to
379e550
Compare
acc337a to
45fc4d5
Compare
45fc4d5 to
9de7756
Compare
979e2f0 to
5f56209
Compare
f2d20d4 to
00e8a99
Compare
|
Do we use those function any where? If not, we can just remove them. |
|
Same comment as above. |
|
We can add a flag |
|
I have a question: will bazel use the python version in the virtual environment or the system python? |
|
Suggestion: - **`c3_example.py`**: Basic C3 with toy examples |
|
Nit. Can we make the build status and coverage status on the same line? |
|
Can we add instruction to install |
|
We don't have |
|
We might consider to add a |
|
Core C3 is actually using Drake dependencies (e.g MathematicalProgram). We can say in those examples, we derive analytical dynamics equations instead of involving Drake's MultibodyPlant. |
|
We can add more a little bit more details such as: The LCS model provides a piecewise-affine approximation of the nonlinear dynamics, generated using the LCS factory. |
|
We don't need comment here. |
|
We also don't need comment here. |
|
Nit. I think the comments seem to be redundant. |
|
Are we using these functions |
|
Note that after merging #10, this test is no longer valid. We'll need a new test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only have some minor comments. Please note that some of the unit tests for LCSFactorySystem and LCSFactory will be obsolete after merging #10
Reviewed 13 of 22 files at r1, 45 of 45 files at r2, all commit messages.
Reviewable status: all files reviewed, 17 unresolved discussions (waiting on @Meow404)
Yeah, I'd want to try and merge this PR first and then add/fix unit tests in #10 after a rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 15 unresolved discussions (waiting on @xuanhien070594)
README.md line 22 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
Can we add instruction to install
bazelorbazelisk
Done.
README.md line 120 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
We don't have
WORKSPACEfile.
Done.
README.md line 126 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
We might consider to add a
Citing C3section where we'll put the BibTeX entry for C3 paper.
Done.
bindings/pyc3/README.md line 38 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
I have a question: will bazel use the python version in the virtual environment or the system python?
My understanding is it will use the version specified in the .bazelrc file
core/c3.h line 203 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
Do we use those function any where? If not, we can just remove them.
Done.
core/c3.h line 213 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
Same comment as above.
Done.
examples/c3_example.cc line 187 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
We can add a flag
verbosefor printing out state.
Done.
examples/README.md line 3 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
Core C3 is actually using Drake dependencies (e.g MathematicalProgram). We can say in those examples, we derive analytical dynamics equations instead of involving Drake's MultibodyPlant.
Done.
examples/README.md line 40 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
We can add more a little bit more details such as: The LCS model provides a piecewise-affine approximation of the nonlinear dynamics, generated using the LCS factory.
Done.
examples/README.md line 53 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
We also don't need comment here.
Done.
examples/README.md line 64 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
We don't need comment here.
Done.
systems/lcs_factory_system.cc line 3 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
We don't need
iostreamright?
Done.
systems/test/systems_test.cc line 328 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
Note that after merging #10, this test is no longer valid. We'll need a new test.
Hoping to merge this PR first, then resolve the dependencies and coverage in #10
core/test/core_test.cc line 358 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
Are we using these functions
GetWarmStartDeltaorGetWarmStartBinaryany where? If not, I think we can remove them.
Done.
bindings/pyc3/README.md line 65 at r2 (raw file):
Complete examples are available in the `examples/python/` directory: - **`c3_example.py`**: Basic C3 optimization example
Done.
|
Suggestion: @article{Aydinoglu2024,
title = {Consensus Complementarity Control for Multi-Contact MPC},
author = {Aydinoglu, Alp and Wei, Adam and Huang, Wei-Cheng and Posa, Michael},
year = {2024},
month = jul,
journal = {IEEE Transactions on Robotics (TRO)},
youtube = {L57Jz3dPwO8},
arxiv = {2304.11259},
doi = {10.1109/TRO.2024.3435423},
url = {https://ieeexplore.ieee.org/document/10614849}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only need to change the citation BibTeX of C3 paper.
Reviewed 9 of 9 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Meow404)
e64ed7a to
1ee8847
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Meow404)
changes:
This change is