feat: Add ContentLayer attribute to designate items to body or furniture #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Auer <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
3 tasks
Signed-off-by: Panos Vagenas <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
…ter in body Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
dolfim-ibm
reviewed
Feb 5, 2025
| # Since version 1.1.0, all NodeItems carry content_layer property. | ||
| # We must assign previous page_header and page_footer instances to furniture. | ||
| # Note: model_validators which check on the version must use "before". | ||
| if "version" in data and data["version"] == "1.0.0": |
There was a problem hiding this comment.
we have already logic in docling-core about checking version numbers: https://github.com/DS4SD/docling-core/blob/main/docling_core/types/doc/document.py#L2947
There was a problem hiding this comment.
Yes, but why do we need that logic? This is not about determining if the version is compatible, it is specifically checking if the version is 1.0.0 (the only version in existence prior to the current version).
dolfim-ibm
reviewed
Feb 5, 2025
Signed-off-by: Christoph Auer <[email protected]>
|
@dolfim-ibm Problem with putting PAGE_HEADER and PAGE_FOOTER in the default labels:
|
PeterStaar-IBM
approved these changes
Feb 5, 2025
dolfim-ibm
approved these changes
Feb 10, 2025
Saidgurbuz
pushed a commit
that referenced
this pull request
Feb 13, 2025
…ure (#148) * feat: Add ContentLayer attribute to designate items to body or furniture Signed-off-by: Christoph Auer <[email protected]> * introduce safer data gen mechanism, update chunking test data Signed-off-by: Panos Vagenas <[email protected]> * Do not make test rely on order in yaml Signed-off-by: Christoph Auer <[email protected]> * chore: format fixes Signed-off-by: Christoph Auer <[email protected]> * fix: legacy_to_docling_doc must use content_layer Signed-off-by: Christoph Auer <[email protected]> * Add content_layer in iterate_items Signed-off-by: Christoph Auer <[email protected]> * Bump format version, add model_validator for old page_header,page_footer in body Signed-off-by: Christoph Auer <[email protected]> * fix: Change to before model_validator Signed-off-by: Christoph Auer <[email protected]> * Update tests Signed-off-by: Christoph Auer <[email protected]> * Address review comments Signed-off-by: Christoph Auer <[email protected]> --------- Signed-off-by: Christoph Auer <[email protected]> Signed-off-by: Panos Vagenas <[email protected]> Co-authored-by: Panos Vagenas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.