Add user profile image to notification list items#655
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR surfaces the sender’s profile image in notification list items by propagating a new profileImage field through the network, mapping, domain, and UI layers.
- Extended the remote
AlarmResponseandNotificationdomain model withprofileImage - Updated
AlarmMapperto includeprofileImage - Modified the Compose UI (
NotificationScreen.kt) to load and display the profile image
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| presentation/src/main/java/daily/dayo/presentation/screen/notification/NotificationScreen.kt | Added profileImage to defaults and updated RoundImageView URL |
| domain/src/main/java/daily/dayo/domain/model/Notification.kt | Added val profileImage: String? to Notification |
| data/src/main/java/daily/dayo/data/mapper/AlarmMapper.kt | Mapped profileImage from DTO to domain model |
| data/src/main/java/daily/dayo/data/datasource/remote/alarm/AlarmResponse.kt | Added @SerializedName("profileImage") val profileImage: String? |
Comments suppressed due to low confidence (2)
domain/src/main/java/daily/dayo/domain/model/Notification.kt:13
- [nitpick] The
Notificationdata class already has animageproperty. IntroducingprofileImagemay cause confusion—consider renamingimageto something likecontentImageorattachmentImageto clarify each field’s purpose.
val profileImage: String?,
data/src/main/java/daily/dayo/data/mapper/AlarmMapper.kt:17
- You’ve added mapping for
profileImage; consider adding a unit test inAlarmMapperTest(or similar) to verify that the DTO’sprofileImagecorrectly maps into the domain model.
profileImage = profileImage,
yuni-ju
approved these changes
May 28, 2025
DongJun-H
added a commit
that referenced
this pull request
Feb 3, 2026
Add user profile image to notification list items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업사항
참고