Skip to content

Add user profile image to notification list items #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DongJun-H merged 2 commits into from
Jun 2, 2025
Merged

Add user profile image to notification list items #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a841540
Add user profile image to notification list items
DongJun-H May 25, 2025
01f12e5
Remove notification profileImage is non-null
DongJun-H May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion data/src/main/java/daily/dayo/data/datasource/remote/alarm/AlarmResponse.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,7 @@ data class AlarmDto(
@SerializedName("memberId")
val memberId: String?,
@SerializedName("postId")
val postId: Long?
val postId: Long?,
@SerializedName("profileImage")
val profileImage: String?,
)
3 changes: 2 additions & 1 deletion data/src/main/java/daily/dayo/data/mapper/AlarmMapper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ fun AlarmDto.toNotification(): Notification {
image = image,
nickname = nickname,
memberId = memberId,
postId = postId
postId = postId,
profileImage = profileImage,
)
}
3 changes: 2 additions & 1 deletion domain/src/main/java/daily/dayo/domain/model/Notification.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@ data class Notification(
val image: String?,
val nickname: String?,
val memberId: String?,
val postId: Long?
val postId: Long?,
val profileImage: String?,
)
4 changes: 3 additions & 1 deletion presentation/src/main/java/daily/dayo/presentation/screen/notification/NotificationScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ fun NotificationContent(
nickname = "",
memberId = "",
postId = 0,
profileImage = "",
)
)
)
Expand Down Expand Up @@ -310,6 +311,7 @@ fun NotificationView(
nickname = "",
memberId = "",
postId = 0,
profileImage = "",
),
context: Context = LocalContext.current,
onClick: () -> Unit = {},
Expand Down Expand Up @@ -353,7 +355,7 @@ fun NotificationView(
modifier = Modifier.weight(1f),
) {
RoundImageView(
imageUrl = "", // TODO USER IMAGE Format: ${BuildConfig.BASE_URL}/images/
imageUrl = "${BuildConfig.BASE_URL}/images/${notification.profileImage}",
context = context,
modifier = Modifier
.size(28.dp)
Expand Down