[ASCII-2746] Strip binaries on dogstatsd and iot builds #33789

pgimalac · 2025-02-06T15:34:44Z

What does this PR do?

Strip binaries in dogstatsd and iot builds.
#33782 (comment) revealed that we don't.

Motivation

Have smaller packages, we already strip the agent packages so it makes sense to strip those too.

Describe how you validated your changes

This just removes debug symbols, if CI passes then the build should be fine.

Possible Drawbacks / Trade-offs

Users of dogstatsd and iot could be relying on those symbols for something (improved debugging).
It's highly unlikely for those builds.

Additional Notes

See #33789 (comment) for the exact size impact, basically reduces the size of dogstatsd and iot packages by 30%.

agent-platform-auto-pr · 2025-02-06T16:01:23Z

[Fast Unit Tests Report]

On pipeline 55233037 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

agent-platform-auto-pr · 2025-02-06T16:13:21Z

Static quality checks ✅

Please find below the results from static quality gates

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	844.97MiB	858.45MiB	203.52MiB	214.3MiB
✅	static_quality_gate_docker_agent_amd64	929.36MiB	942.69MiB	310.75MiB	321.56MiB

cit-pr-commenter · 2025-02-06T16:39:33Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1b5eb905-3639-412a-bad0-e573262a1d46

Baseline: 2c9b0cf
Comparison: 05aec18
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.09	[-1.97, +4.14]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.28	[-0.59, +1.16]	1	Logs
➖	quality_gate_idle	memory utilization	+0.24	[+0.21, +0.28]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.07	[-0.40, +0.53]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.04	[-0.84, +0.91]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.02	[-0.79, +0.83]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.02	[-0.61, +0.65]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.02	[-0.05, +0.10]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.02	[-0.80, +0.84]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.27, +0.29]	1	Logs
➖	file_tree	memory utilization	+0.01	[-0.07, +0.09]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.02, +0.03]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.80, +0.78]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.03	[-0.92, +0.85]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.05	[-0.77, +0.67]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.34	[-1.41, -1.26]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-02-06T17:59:03Z

Uncompressed package size comparison

Comparison with ancestor 2c9b0cf83d163e2ec32902670eff57b9e3479ead

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-aarch64-rpm	0.00MB	✅	871.29MB	871.29MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	873.70MB	873.70MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	883.44MB	883.44MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	883.44MB	883.44MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	861.57MB	861.57MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	446.07MB	446.07MB	0.50MB
datadog-dogstatsd-arm64-deb	-16.71MB	✅	39.86MB	56.57MB	0.50MB
datadog-dogstatsd-amd64-deb	-17.50MB	✅	41.60MB	59.10MB	0.50MB
datadog-dogstatsd-x86_64-rpm	-17.50MB	✅	41.68MB	59.18MB	0.50MB
datadog-dogstatsd-x86_64-suse	-17.50MB	✅	41.68MB	59.18MB	0.50MB
datadog-iot-agent-arm64-deb	-23.70MB	✅	59.07MB	82.77MB	0.50MB
datadog-iot-agent-aarch64-rpm	-23.70MB	✅	59.14MB	82.84MB	0.50MB
datadog-iot-agent-x86_64-rpm	-24.68MB	✅	61.88MB	86.56MB	0.50MB
datadog-iot-agent-x86_64-suse	-24.68MB	✅	61.88MB	86.56MB	0.50MB
datadog-iot-agent-amd64-deb	-24.68MB	✅	61.81MB	86.49MB	0.50MB

Decision

✅ Passed

remeh

LGTM

…/strip-bin-iot-dogstatsd

truthbk · 2025-02-07T12:14:12Z

omnibus/config/projects/dogstatsd.rb

+
+if linux_target? or windows_target?
+  strip_build windows_target? || !do_package
+  debug_path '.debug'


I can't fully remember how the debug package was built, but can you double-check all these symbols are also available in said debug packages 🙇

For the agent we have a debug package, but we don't for dogstatsd and iot
I discussed this internally and the answer seemed to be that we can strip right now and if the need arises then we can provide debug symbols

We're discussing this within agent delivery, but yeah so far the plan would be to not care about the debug packages.

Should we want to ship those, it can easily be done in a sprint

pgimalac · 2025-02-12T13:59:26Z

/merge

dd-devflow · 2025-02-12T13:59:31Z

View all feedbacks in Devflow UI.
2025-02-12 13:59:30 UTC ℹ️ Start processing command /merge

2025-02-12 13:59:34 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 30m.

2025-02-12 14:32:16 UTC ℹ️ MergeQueue: This merge request was merged

feat: strip binaries on dogstatsd and iot builds

154bffc

pgimalac added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-delivery labels Feb 6, 2025

pgimalac requested a review from a team as a code owner February 6, 2025 15:34

pgimalac requested a review from chouquette February 6, 2025 15:34

github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 6, 2025

pgimalac added 2 commits February 6, 2025 18:12

fix: remove debug_path to avoid debug build

b05d092

fix: exclude debug symbols from build

65fd326

pgimalac changed the title ~~Strip binaries on dogstatsd and iot builds~~ [ASCII-2746] Strip binaries on dogstatsd and iot builds Feb 6, 2025

fix: revert to previous but use || instead of or

cf3d339

remeh approved these changes Feb 7, 2025

View reviewed changes

Merge branch 'main' of github.com:DataDog/datadog-agent into pgimalac…

05aec18

…/strip-bin-iot-dogstatsd

truthbk reviewed Feb 7, 2025

View reviewed changes

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Feb 7, 2025

chouquette approved these changes Feb 12, 2025

View reviewed changes

dd-mergequeue bot merged commit 5a71ece into main Feb 12, 2025
230 checks passed

dd-mergequeue bot deleted the pgimalac/strip-bin-iot-dogstatsd branch February 12, 2025 14:32

github-actions bot added this to the 7.64.0 milestone Feb 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ASCII-2746] Strip binaries on dogstatsd and iot builds #33789

[ASCII-2746] Strip binaries on dogstatsd and iot builds #33789

pgimalac commented Feb 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 6, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 6, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

agent-platform-auto-pr bot commented Feb 6, 2025 •

edited

Loading

remeh left a comment

truthbk Feb 7, 2025

pgimalac Feb 7, 2025

chouquette Feb 7, 2025

pgimalac commented Feb 12, 2025

dd-devflow bot commented Feb 12, 2025 •

edited

Loading

[ASCII-2746] Strip binaries on dogstatsd and iot builds #33789

[ASCII-2746] Strip binaries on dogstatsd and iot builds #33789

Conversation

pgimalac commented Feb 6, 2025 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Feb 6, 2025 • edited Loading

agent-platform-auto-pr bot commented Feb 6, 2025 • edited Loading

Static quality checks ✅

Info

cit-pr-commenter bot commented Feb 6, 2025 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

agent-platform-auto-pr bot commented Feb 6, 2025 • edited Loading

Uncompressed package size comparison

Decision

remeh left a comment

Choose a reason for hiding this comment

truthbk Feb 7, 2025

Choose a reason for hiding this comment

pgimalac Feb 7, 2025

Choose a reason for hiding this comment

chouquette Feb 7, 2025

Choose a reason for hiding this comment

pgimalac commented Feb 12, 2025

dd-devflow bot commented Feb 12, 2025 • edited Loading

pgimalac commented Feb 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 6, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 6, 2025 •

edited

Loading

dd-devflow bot commented Feb 12, 2025 •

edited

Loading