Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII-2746] Strip binaries on dogstatsd and iot builds #33789

Merged
merged 5 commits into from
Feb 12, 2025
Merged

[ASCII-2746] Strip binaries on dogstatsd and iot builds #33789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
154bffc
feat: strip binaries on dogstatsd and iot builds
pgimalac Feb 6, 2025
b05d092
fix: remove debug_path to avoid debug build
pgimalac Feb 6, 2025
65fd326
fix: exclude debug symbols from build
pgimalac Feb 6, 2025
cf3d339
fix: revert to previous but use || instead of or
pgimalac Feb 7, 2025
05aec18
Merge branch 'main' of github.com:DataDog/datadog-agent into pgimalac…
pgimalac Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions omnibus/config/projects/dogstatsd.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,3 +220,8 @@

exclude '\.git*'
exclude 'bundler\/git'

if linux_target? or windows_target?
strip_build windows_target? || !do_package
debug_path '.debug'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't fully remember how the debug package was built, but can you double-check all these symbols are also available in said debug packages 🙇

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the agent we have a debug package, but we don't for dogstatsd and iot
I discussed this internally and the answer seemed to be that we can strip right now and if the need arises then we can provide debug symbols

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're discussing this within agent delivery, but yeah so far the plan would be to not care about the debug packages.

Should we want to ship those, it can easily be done in a sprint

end
5 changes: 5 additions & 0 deletions omnibus/config/projects/iot-agent.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,3 +232,8 @@

exclude '\.git*'
exclude 'bundler\/git'

if linux_target? or windows_target?
strip_build windows_target? || !do_package
debug_path ".debug"
end
Loading