Ensure sessionStartedListenerTests requiring bridge enforce Old architecture#939
Merged
sbarrio merged 1 commit intoJul 18, 2025
Conversation
…stener tests enforce old arch
sbarrio
changed the title
marco-saia-datadog
approved these changes
Jul 18, 2025
sbarrio
deleted the
sbarrio/fix/fix-android-session-started-listener-tests-on-new-arch
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We had two flaky tests for
DdSdkSessionStartedListener. These tests require a valid bridge to be present, which is not if the tests are run under new architecture. This PR adds a new@TestOnlyfunction that allows for tests to set the instance newArchitecture value so the test can properly use and observe the bridge.Motivation
We should not have any flaky tests.
Additional notes
Review checklist (to be filled by reviewers)