Skip to content

Ensure sessionStartedListenerTests requiring bridge enforce Old architecture #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbarrio merged 1 commit into from
Jul 18, 2025
Merged

Ensure sessionStartedListenerTests requiring bridge enforce Old architecture #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkSessionStartedListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ internal class DdSdkSessionStartedListener private constructor(): RumSessionList
this.exceptionHandler = exceptionHandler
}

@TestOnly
fun setIsNewArchitecture(isNewArch: Boolean) {
this.isNewArchitecture = isNewArch
}

private fun hasValidBridge(): Boolean {
val context = reactContext ?: return false
val instance = context.catalystInstance ?: return false
Expand Down
2 changes: 2 additions & 0 deletions ...s/core/android/src/test/kotlin/com/datadog/reactnative/DdSdkSessionStartedListenerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ internal class DdSdkSessionStartedListenerTest {
val instance = DdSdkSessionStartedListener.getInstance()
instance.setReactContext(mockReactContext)
instance.setExceptionHandler(mockExceptionHandler)
instance.setIsNewArchitecture(false)

val passedArgs = mutableListOf<String>()
instance.setConvertToNativeArray {
Expand Down Expand Up @@ -124,6 +125,7 @@ internal class DdSdkSessionStartedListenerTest {

val mockConvertToNativeArray = mock<(array: Array<String>) -> NativeArray?>()
instance.setConvertToNativeArray(mockConvertToNativeArray)
instance.setIsNewArchitecture(false)

// WHEN
instance.onSessionStarted("TEST-SESSION-ID", false)
Expand Down
Loading